Change default fallback encoding for GetEncoding in Start-Transcript - #13732
Merged
Rob Holt (rjmholt) merged 3 commits intoOct 9, 2020
Merged
Conversation
The System.Management.Automation.Utils.GetEncoding method should return UTF8 without BOM as a default but was returning ASCII. This is fixed by returning an instance of the Utf8Encoding with the BOM set to false.
Rob Holt (rjmholt)
requested review from
James Truher (JamesWTruher) and
Dongbo Wang (daxian-dbw)
and removed request for
Dongbo Wang (daxian-dbw)
October 1, 2020 21:02
Collaborator
|
@PowerShell/powershell-committee please review this potentially breaking change, noting the linked issues |
Add the label for the boolean argument Co-authored-by: Ilya <darpa@yandex.ru>
Collaborator
|
For PowerShell-Committee:
|
Member
|
ASCII being a subset of UTF8 makes this an unlikely impactful breaking change (bucket 3) for me. Seems like the right thing to do. |
Member
|
@PowerShell/powershell-committee reviewed this, we agree that this is a bucket 3 breaking change that is unlikely to have negative impact on anyone. This should have been changed along with the other encoding changes to UTF-8 by default and is a bug fix. |
Rob Holt (rjmholt)
approved these changes
Oct 8, 2020
Collaborator
|
Dongbo Wang (@daxian-dbw) please re-review if you can |
Ilya (iSazonov)
approved these changes
Oct 9, 2020
Contributor
Author
|
Rob Holt (@rjmholt) I'm not sure about those CI fails, do I need to do something about them? |
Collaborator
|
I restarted CI Windows. |
Collaborator
|
Xavier Hahn (@Gimly) Thanks for your contribution! |
|
🎉 Handy links: |
Thatgfsj (Thatgfsj)
pushed a commit
to Thatgfsj/PowerShell
that referenced
this pull request
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The System.Management.Automation.Utils.GetEncoding method should return UTF8 without BOM as a default but was returning ASCII.
This is fixed by returning an instance of the Utf8Encoding with the BOM set to false as a default fallback encoding.
PR Context
This should fix #13678 and fix partially #13677
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.