Skip to content

Simplify delegate creation - #13578

Merged
Ilya (iSazonov) merged 5 commits into
PowerShell:masterfrom
xtqqczze:RCS1048
Nov 5, 2020
Merged

Simplify delegate creation#13578
Ilya (iSazonov) merged 5 commits into
PowerShell:masterfrom
xtqqczze:RCS1048

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Sep 4, 2020

Copy link
Copy Markdown
Contributor

PR Summary

PR Context

PR Checklist

@xtqqczze

xtqqczze commented Sep 4, 2020

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Should I fix Codacy issues, "Remove the type specification; it is redundant." (I am not sure this would aid readability)

@iSazonov

Copy link
Copy Markdown
Collaborator

Should I fix Codacy issues, "Remove the type specification; it is redundant." (I am not sure this would aid readability)

No. It looks as false positive and does not add readability.

@ghost ghost added the Review - Needed The PR is being reviewed label Sep 18, 2020
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) Is master currently open for merging?

@iSazonov

Copy link
Copy Markdown
Collaborator

xtqqczze I can ask MSFT team there PowerShell/PowerShell-RFC#263 :-)

@ghost ghost removed the Review - Needed The PR is being reviewed label Oct 12, 2020
@SteveL-MSFT

Copy link
Copy Markdown
Member

Ilya (@iSazonov) yes, master branch should now be 7.2

@xtqqczze

Copy link
Copy Markdown
Contributor Author

Steve Lee (@SteveL-MSFT) Please could you review or add review needed tag.

@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Oct 13, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Oct 20, 2020
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 5, 2020
@iSazonov

Copy link
Copy Markdown
Collaborator

xtqqczze Please resolve merge conflicts and add references to rule docs in the PR description.

@xtqqczze

xtqqczze commented Nov 5, 2020

Copy link
Copy Markdown
Contributor Author

xtqqczze Please resolve merge conflicts and add references to rule docs in the PR description.

Ilya (@iSazonov) Done.

@iSazonov
Ilya (iSazonov) merged commit d6727dc into PowerShell:master Nov 5, 2020
@xtqqczze
xtqqczze deleted the RCS1048 branch November 5, 2020 17:55
@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
* Autofix RCS1048

* Autofix RCS1021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants