Skip to content

Fix accessor order - #13538

Merged
Ilya (iSazonov) merged 5 commits into
PowerShell:masterfrom
xtqqczze:SA1212
Nov 5, 2020
Merged

Fix accessor order#13538
Ilya (iSazonov) merged 5 commits into
PowerShell:masterfrom
xtqqczze:SA1212

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Aug 28, 2020

Copy link
Copy Markdown
Contributor

PR Summary

  • Fix SA1212:PropertyAccessorsMustFollowOrder
    • Microsoft.PowerShell.Commands.Utility
    • Microsoft.Management.Infrastructure.CimCmdlets
    • Microsoft.PowerShell.Commands.Management
    • Microsoft.WSMan.Management

PR Context

PR Checklist

@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 1, 2020
@xtqqczze xtqqczze changed the title WIP: Fix SA1212 WIP: Fix accessor order Sep 3, 2020
@xtqqczze xtqqczze changed the title WIP: Fix accessor order Fix accessor order Sep 3, 2020
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 3, 2020
@xtqqczze
xtqqczze marked this pull request as ready for review September 3, 2020 20:46
@ghost ghost added the Review - Needed The PR is being reviewed label Sep 11, 2020
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@xtqqczze

Copy link
Copy Markdown
Contributor Author

Travis Plunk (@TravisEz13) Do you think it would be helpful to split this PR into a series of smaller PRs?

@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Nov 5, 2020
@iSazonov
Ilya (iSazonov) merged commit eaad6c2 into PowerShell:master Nov 5, 2020
@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 5, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Nov 5, 2020
@xtqqczze
xtqqczze deleted the SA1212 branch November 5, 2020 16:24
@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
* Fix Microsoft.PowerShell.Commands.Utility

* Fix System.Management.Automation

* Fix Microsoft.Management.Infrastructure.CimCmdlets

* Fix Microsoft.PowerShell.Commands.Management

* Fix Microsoft.WSMan.Management
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants