Skip to content

Replace magic number with constant in PDH - #13536

Merged
Ilya (iSazonov) merged 2 commits into
PowerShell:masterfrom
xtqqczze:use-uint-pdh2
Nov 5, 2020
Merged

Replace magic number with constant in PDH#13536
Ilya (iSazonov) merged 2 commits into
PowerShell:masterfrom
xtqqczze:use-uint-pdh2

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Aug 28, 2020

Copy link
Copy Markdown
Contributor

PR Summary

  • Replace magic number: 0 with PdhResults.PDH_CSTATUS_VALID_DATA
  • Remove useless assignments (fix Codacy issues)

https://docs.microsoft.com/en-us/windows/win32/perfctrs/checking-pdh-interface-return-values

Best approach to review is commit by commit.

PR Context

Follow-up #13502

PR Checklist

@xtqqczze xtqqczze changed the title Replace magic number with constant Replace magic number with constant in PDH Aug 28, 2020
@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Aug 29, 2020
@ghost ghost added the Review - Needed The PR is being reviewed label Sep 5, 2020
@ghost

Copy link
Copy Markdown

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

@ghost ghost removed the Review - Needed The PR is being reviewed label Nov 5, 2020
@iSazonov
Ilya (iSazonov) merged commit 45ffc2c into PowerShell:master Nov 5, 2020
@iSazonov Ilya (iSazonov) added this to the 7.2.0-preview.1 milestone Nov 5, 2020
@xtqqczze
xtqqczze deleted the use-uint-pdh2 branch November 5, 2020 16:22
@ghost

Copy link
Copy Markdown

🎉v7.2.0-preview.1 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
* Replace magic number with constant

* Remove useless assignment (codacy)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants