Skip to content

WIP: Fix IDE0005: Remove unnecessary usings - #13504

Closed
xtqqczze wants to merge 1 commit into
PowerShell:masterfrom
xtqqczze:IDE0005
Closed

WIP: Fix IDE0005: Remove unnecessary usings#13504
xtqqczze wants to merge 1 commit into
PowerShell:masterfrom
xtqqczze:IDE0005

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Aug 22, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

@iSazonov
Ilya (iSazonov) self-requested a review August 24, 2020 19:00
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Aug 28, 2020
@ghost ghost added the Stale label Sep 12, 2020
@ghost

Deleted user (ghost) commented Sep 12, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@rjmholt Rob Holt (rjmholt) added the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label Sep 14, 2020
@ghost ghost closed this Sep 24, 2020
@anmenaga Andrew (anmenaga) removed the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label Sep 29, 2020
@anmenaga

Andrew (anmenaga) commented Sep 29, 2020

Copy link
Copy Markdown

Maintainers think this is a low risk change, considering that a build break will detect any error in this change;
however conflict must be fixed and CI have to be passing; please put back "Review - Maintainer" label once this is updated.

@ghost ghost removed the Stale label Sep 29, 2020
@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Oct 13, 2020
@ghost ghost added the Stale label Oct 31, 2020
@ghost

Deleted user (ghost) commented Oct 31, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@iSazonov

Ilya (iSazonov) commented Nov 5, 2020

Copy link
Copy Markdown
Collaborator

xtqqczze Please split the PR by project/folder.

@ghost ghost removed the Stale label Nov 5, 2020
@xtqqczze xtqqczze changed the title Remove unused usings WIP: Fix IDE0005: Remove unused usings Nov 9, 2020
@xtqqczze xtqqczze changed the title WIP: Fix IDE0005: Remove unused usings WIP: Fix IDE0005: Remove unnecessary import Nov 9, 2020
@xtqqczze xtqqczze changed the title WIP: Fix IDE0005: Remove unnecessary import WIP: Fix IDE0005: Remove unnecessary usings Nov 10, 2020
@iSazonov

Ilya (iSazonov) commented Nov 21, 2020

Copy link
Copy Markdown
Collaborator

xtqqczze Can we close?

This was referenced Nov 21, 2020
Merged
Merged
Merged
Merged
Merged
This was referenced Nov 21, 2020
Merged
Merged
Merged
@xtqqczze

xtqqczze commented Nov 22, 2020

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) We still have System.Management.Automation 🙁

@ghost ghost added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels Nov 22, 2020
@xtqqczze xtqqczze mentioned this pull request Nov 29, 2020
Merged
@ghost

Deleted user (ghost) commented Dec 10, 2020

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

@ghost ghost added the Stale label Dec 10, 2020
@ghost ghost closed this Dec 21, 2020
@ghost ghost closed this Dec 31, 2020
@stan-sz

stan-sz commented Nov 30, 2022 •
edited
Loading

Copy link
Copy Markdown

Turning this code analysis rule to a warning/error mode helps maintain leaner code base and open up path to removed unused Project/PackageReferences from projects. Just

Based on dotnet/roslyn#41640 (comment) this property is already enabled for this repo:

PowerShell/PowerShell.Common.props

Line 146 in dd3a6a1

<GenerateDocumentationFile>true</GenerateDocumentationFile>

@ghost ghost removed the Stale label Nov 30, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov Ilya (iSazonov) Awaiting requested review from iSazonov
Copilot code review Copilot
Copilot will automatically review once the pull request is marked ready for review

Assignees

@rjmholt Rob Holt (rjmholt)

Labels

Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@xtqqczze @anmenaga @iSazonov @stan-sz @rjmholt