Skip to content

Release pipeline fixes - #13473

Merged
Dongbo Wang (daxian-dbw) merged 3 commits into
PowerShell:masterfrom
adityapatwardhan:ReleasePipelineFixes
Aug 18, 2020
Merged

Release pipeline fixes#13473
Dongbo Wang (daxian-dbw) merged 3 commits into
PowerShell:masterfrom
adityapatwardhan:ReleasePipelineFixes

Conversation

@adityapatwardhan

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) commented Aug 18, 2020

Copy link
Copy Markdown
Member

PR Summary

Multiple fixes for the release pipeline to ix deployment of pwsh.deps.json stage and nuget release stage.

PR Context

Fixes were done in release branch. Bringing them over to master.

PR Checklist

#Exclude all global tool packages. Their names start with 'PowerShell.'
Copy-Item "$ENV:PIPELINE_WORKSPACE/releasePipeline/finalResults/*.nupkg" -Destination "$(Pipeline.Workspace)/release" -Exclude "PowerShell.*.nupkg" -Force
$null = New-Item -ItemType Directory -Path "$(Pipeline.Workspace)/release"
Copy-Item "$ENV:PIPELINE_WORKSPACE/releasePipeline/finalResults/*.nupkg" -Destination "$(Pipeline.Workspace)/release" -Exclude "PowerShell.*.nupkg" -Force -Verbose

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing our inclusion of -Verbose here, makes me think it would be really nice if we just had a variable we could set to make the whole build spit out verbose PowerShell output. But it does also make sense as a default

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting all verbose can be too much sometimes. Specially with import-module etc.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its more for logging what gets copied to where.

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title Release pipeline fixes WIP: Release pipeline fixes Aug 18, 2020
@adityapatwardhan Aditya Patwardhan (adityapatwardhan) changed the title WIP: Release pipeline fixes Release pipeline fixes Aug 18, 2020
@adityapatwardhan

Copy link
Copy Markdown
Member Author

Dongbo Wang (@daxian-dbw) I believe this is ready to merge. Other CIs will not run as this is a yml only change.

@daxian-dbw

Copy link
Copy Markdown
Member

PoshChan-Bot (@PoshChan) Please remind me in 1 hour

@PoshChan

Copy link
Copy Markdown
Collaborator

Dongbo Wang (@daxian-dbw), this is the reminder you requested 1 hour ago

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 1e940f5 into PowerShell:master Aug 18, 2020
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Sep 8, 2020
@ghost

Copy link
Copy Markdown

🎉v7.1.0-preview.7 has been released which incorporates this pull request.:tada:

Handy links:

@ghost

Copy link
Copy Markdown

🎉v7.0.6 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Backport-7.0.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants