Enable IDE0074: Use coalesce compound assignment by xtqqczze · Pull Request #13396 · PowerShell/PowerShell

xtqqczze · 2020-08-11T02:57:00Z

PR Summary

Use C# 8.0 null-coalescing assignment.

PR Context

https://docs.microsoft.com/en-us/dotnet/fundamentals/code-analysis/style-rules/ide0054-ide0074

PR Checklist

PR has a meaningful title
- Use the present tense and imperative mood when describing your changes
Summarized changes
Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
This PR is ready to merge and is not Work in Progress.
- If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
Breaking changes
- None
- OR
- [NA] Experimental feature(s) needed
  - [NA] Experimental feature name(s):
User-facing changes
- Not Applicable
- OR
- [NA] Documentation needed
  - [NA] Issue filed:
Testing - New and feature
- N/A or can only be tested interactively
- OR
- [NA] Make sure you've added a new test if existing tests do not effectively test the code changed
Tooling
- I have considered the user experience from a tooling perspective and don't believe tooling will be impacted.
- OR
- [NA] I have considered the user experience from a tooling perspective and enumerated concerns in the summary. This may include:
  - Impact on PowerShell Editor Services which is used in the PowerShell extension for VSCode (which runs in a different PS Host).
  - Impact on Completions (both in the console and in editors) - one of PowerShell's most powerful features.
  - Impact on PSScriptAnalyzer (which provides linting & formatting in the editor extensions).
  - Impact on EditorSyntax (which provides syntax highlighting with in VSCode, GitHub, and many other editors).

This change is

Deleted user (ghost) · 2020-08-19T14:00:21Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

xtqqczze · 2020-08-28T20:50:57Z

Codacy issue is not new.

xtqqczze · 2020-08-28T20:55:25Z

Travis Plunk (@TravisEz13) can you please review?

Dongbo Wang (daxian-dbw) · 2020-09-01T21:33:55Z

@PowerShell/powershell-maintainers reviewed this PR and agreed to accept it for 7.2-preview, namely delay merging this PR until after 7.1-RC1 release branch gets created. The decision is based on the following reason(s):

The changes make sense, but they are actual code changes and the chance of regression is relatively high. So it requires line-by-line review to make sure changes are correct.

Ilya (iSazonov) · 2020-09-02T03:17:01Z

Set to Draft till 7.2 Preview1.

Deleted user (ghost) · 2020-09-20T08:00:12Z

This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 15 days. It will be closed if no further activity occurs within 10 days of this comment.

Ilya (iSazonov) · 2020-10-16T03:59:20Z

xtqqczze Is it still Draft?

Travis Plunk (TravisEz13)

Reviewed 11 out of 55 files.

Travis Plunk (TravisEz13) · 2020-10-25T16:13:20Z

PoshChan-Bot (@PoshChan) Please remind me in 7 days

Deleted user (ghost) · 2020-11-03T02:00:13Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

Ilya (iSazonov) · 2020-11-05T05:22:24Z

xtqqczze Please resolve merge conflicts.

xtqqczze · 2020-11-05T16:45:31Z

Resolved merge conflicts.

Ilya (iSazonov) · 2020-11-05T17:32:00Z

Travis Plunk (@TravisEz13) Do you want to continue the code review?

Deleted user (ghost) · 2020-11-13T02:00:09Z

This pull request has been automatically marked as Review Needed because it has been there has not been any activity for 7 days.
Maintainer, please provide feedback and/or mark it as Waiting on Author

xtqqczze · 2020-11-25T12:24:44Z

Ilya (@iSazonov) Can we merge?

xtqqczze · 2020-11-26T11:57:53Z

Ilya (@iSazonov) CodeFactor is showing 3542 fixed issues for this PR taking us from grade F to grade D. Unfortunately the fixed issues list is not accurate :(

Ilya (iSazonov) · 2020-11-26T12:17:13Z

xtqqczze Perhaps it is because the PR was old.

You could ask them https://www.codefactor.io/contact or twitter.

Contact
Quality software, faster.

xtqqczze · 2020-12-02T10:21:11Z

xtqqczze Perhaps it is because the PR was old.

You could ask them https://www.codefactor.io/contact or twitter.

Issue opened: codefactor-io/codefactor#27.

Deleted user (ghost) · 2020-12-15T21:34:35Z

🎉v7.2.0-preview.2 has been released which incorporates this pull request.:tada:

Handy links:

Release Notes

xtqqczze · 2020-12-16T14:43:36Z

xtqqczze we have prioritized this ticket and it is currently Work-In-Progress. Some updates have already been pushed to production so you should already see improved analysis results for C# 8.0 and 9.0. The full scope will be rolled out by the end of January 2021.

Originally posted by Kestas (@kaskas) in codefactor-io/codefactor#27 (comment)

* Autofix IDE0074: Use compound assignment

xtqqczze requested review from Steve Lee (SteveL-MSFT), Travis Plunk (TravisEz13), Aditya Patwardhan (adityapatwardhan), Andrew (anmenaga) and Dongbo Wang (daxian-dbw) as code owners August 11, 2020 02:57

ghost assigned Ilya (iSazonov) Aug 11, 2020

Ilya (iSazonov) added Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log labels Aug 11, 2020

Ilya (iSazonov) approved these changes Aug 11, 2020

View reviewed changes

Rain Sallow (/u/ta11ow) (vexx32) reviewed Aug 11, 2020

View reviewed changes

Comment thread src/System.Management.Automation/engine/interpreter/AddInstruction.cs Outdated

Rain Sallow (/u/ta11ow) (vexx32) approved these changes Aug 11, 2020

View reviewed changes

Ilya (iSazonov) added the size/XL label Aug 12, 2020

ghost added the Review - Needed The PR is being reviewed label Aug 19, 2020

ghost removed the Review - Needed The PR is being reviewed label Sep 1, 2020

Dongbo Wang (daxian-dbw) removed the Review - Maintainer The PR/issue needs a review from the PowerShell repo Maintainers label Sep 1, 2020

Ilya (iSazonov) marked this pull request as draft September 2, 2020 03:16

ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Sep 5, 2020

ghost added the Stale label Sep 20, 2020

ghost closed this Sep 30, 2020

Ilya (iSazonov) reopened this Oct 16, 2020

ghost removed the Stale label Oct 16, 2020

xtqqczze marked this pull request as ready for review October 22, 2020 14:12

ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Oct 22, 2020

xtqqczze changed the title ~~Fix IDE0074: Use compound assignment~~ Fix IDE0074: Use coalesce compound assignment Oct 22, 2020

xtqqczze mentioned this pull request Oct 22, 2020

Enable IDE0054: Use compound assignment #13546

Merged

8 tasks

Travis Plunk (TravisEz13) reviewed Oct 25, 2020

View reviewed changes

xtqqczze added 2 commits October 26, 2020 16:26

Merge branch 'master' into IDE0074

5d713a9

Set rule to warning in .globalconfig

46595ec

xtqqczze changed the title ~~Fix IDE0074: Use coalesce compound assignment~~ Enable IDE0074: Use coalesce compound assignment Oct 26, 2020

ghost added the Review - Needed The PR is being reviewed label Nov 3, 2020

Merge branch 'master' into IDE0074

aaab0ae

ghost removed the Review - Needed The PR is being reviewed label Nov 5, 2020

Merge branch 'master' into IDE0074

b117a0b

ghost added the Review - Needed The PR is being reviewed label Nov 13, 2020

Ilya (iSazonov) merged commit 0d1ea73 into PowerShell:master Nov 25, 2020

ghost removed the Review - Needed The PR is being reviewed label Nov 25, 2020

Ilya (iSazonov) added this to the 7.2.0-preview.2 milestone Nov 25, 2020

xtqqczze mentioned this pull request Dec 2, 2020

Unfixed StyleCop issues shown as fixed codefactor-io/codefactor#27

Closed

xtqqczze deleted the IDE0074 branch March 22, 2021 23:10

xtqqczze mentioned this pull request Mar 22, 2021

Remove unnecessary Array -> List -> Array conversion in ProcessBaseCommand.AllProcesses #15052

Merged

8 tasks

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026

Enable IDE0074: Use coalesce compound assignment (PowerShell#13396)

6a1e5ea

* Autofix IDE0074: Use compound assignment

Uh oh!

Conversation

xtqqczze commented Aug 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

PR Context

PR Checklist

Uh oh!

Uh oh!

Deleted user (ghost) commented Aug 19, 2020

Uh oh!

xtqqczze commented Aug 28, 2020

Uh oh!

xtqqczze commented Aug 28, 2020

Uh oh!

Dongbo Wang (daxian-dbw) commented Sep 1, 2020

Uh oh!

Ilya (iSazonov) commented Sep 2, 2020

Uh oh!

Deleted user (ghost) commented Sep 20, 2020

Uh oh!

Ilya (iSazonov) commented Oct 16, 2020

Uh oh!

Travis Plunk (TravisEz13) left a comment

Choose a reason for hiding this comment

Uh oh!

Travis Plunk (TravisEz13) commented Oct 25, 2020

Uh oh!

Deleted user (ghost) commented Nov 3, 2020

Uh oh!

Ilya (iSazonov) commented Nov 5, 2020

Uh oh!

xtqqczze commented Nov 5, 2020

Uh oh!

Ilya (iSazonov) commented Nov 5, 2020

Uh oh!

Deleted user (ghost) commented Nov 13, 2020

Uh oh!

xtqqczze commented Nov 25, 2020

Uh oh!

xtqqczze commented Nov 26, 2020

Uh oh!

Ilya (iSazonov) commented Nov 26, 2020 • edited by unfurl-links Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

xtqqczze commented Dec 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Deleted user (ghost) commented Dec 15, 2020

Uh oh!

xtqqczze commented Dec 16, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

xtqqczze commented Aug 11, 2020 •

edited

Loading

Ilya (iSazonov) commented Nov 26, 2020 •

edited by unfurl-links Bot

Loading

xtqqczze commented Dec 2, 2020 •

edited

Loading