Skip to content

Revert "Use is null syntax" - #13322

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
masterfrom
revert-13277-isnull
Jul 30, 2020
Merged

Revert "Use is null syntax"#13322
Dongbo Wang (daxian-dbw) merged 1 commit into
masterfrom
revert-13277-isnull

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Jul 30, 2020

Copy link
Copy Markdown
Member

Reverts #13277

Quote from #13277 (comment)

As for this PR, the rest of maintainers discussed about it offline, and we all agree that we shouldn't force is null over == null. We think they clearly are appropriate in different scenarios. Changes in this PR will not only result in conflicts in other existing PRs, but also raise disputes in future contributions because people will continue to use == null and argue for it. So we decided to revert this PR.

@daxian-dbw

Dongbo Wang (daxian-dbw) commented Jul 30, 2020

Copy link
Copy Markdown
Member Author

PoshChan-Bot (@PoshChan) Please remind me in 1 hour

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 4b9b078 into master Jul 30, 2020
@daxian-dbw
Dongbo Wang (daxian-dbw) deleted the revert-13277-isnull branch July 30, 2020 23:06
@PoshChan

PoshChan-Bot (PoshChan) commented Jul 30, 2020

Copy link
Copy Markdown
Collaborator

Dongbo Wang (@daxian-dbw), this is the reminder you requested 1 hour ago

@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jul 30, 2020
@daxian-dbw Dongbo Wang (daxian-dbw) added this to the 7.1.0-preview.7 milestone Jul 30, 2020
@daxian-dbw Dongbo Wang (daxian-dbw) mentioned this pull request Aug 3, 2020
Merged
14 tasks
@TravisEz13 Travis Plunk (TravisEz13) modified the milestones: 7.1.0-preview.7, 7.1.0-preview.6 Aug 5, 2020
Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
@daxian-dbw
Revert "Use is null syntax (PowerShell#13277)" (PowerShell#13322)
b9f368a 
This reverts commit be94fae.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adityapatwardhan Aditya Patwardhan (adityapatwardhan) Awaiting requested review from adityapatwardhan adityapatwardhan is a code owner
@anmenaga Andrew (anmenaga) Awaiting requested review from anmenaga
@SteveL-MSFT Steve Lee (SteveL-MSFT) Awaiting requested review from SteveL-MSFT
@TravisEz13 Travis Plunk (TravisEz13) Awaiting requested review from TravisEz13 TravisEz13 is a code owner
1 more reviewer
@rjmholt Rob Holt (rjmholt) rjmholt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@anmenaga Andrew (anmenaga)

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Milestone

7.1.0-preview.6

Development

Successfully merging this pull request may close these issues.

5 participants

@daxian-dbw @PoshChan @rjmholt @TravisEz13 @anmenaga