Remove ComEnumerator as COM objects using IEnumerator is now supported in .NET 5#13259
Merged
iSazonov merged 1 commit intoPowerShell:masterfrom Jul 29, 2020
Merged
Remove ComEnumerator as COM objects using IEnumerator is now supported in .NET 5#13259iSazonov merged 1 commit intoPowerShell:masterfrom
ComEnumerator as COM objects using IEnumerator is now supported in .NET 5#13259iSazonov merged 1 commit intoPowerShell:masterfrom
Conversation
iSazonov
approved these changes
Jul 24, 2020
Member
Author
|
@iSazonov I think it's ready to merge :) thanks! |
|
🎉 Handy links: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #12881
.NET 5 now support COM objects using
IEnumerator(IEnumVARIANT) (the fix is in .NET 5 preview 7), so in our code, theComEnumerator, that handlesIEnumVARIANTcan be removed.The
ComEnumeratorwas introduced in #4553 3 years ago to make PowerShell able to enumerate COM object.The support for COM objects that use
IEnumerablewas back in .NET 3.1, so #11795 reverted some of our changes.This is a follow-up PR, to remove the remaining
ComEnumeratorcode since now .NET 5 finally supports COM objects that useIEnumerator.No new test is needed.
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.