Skip to content

Code redundancy fixes - #12916

Merged
Ilya (iSazonov) merged 7 commits into
PowerShell:masterfrom
xtqqczze:RCS-Redundancy-fixes
Jun 11, 2020
Merged

Code redundancy fixes#12916
Ilya (iSazonov) merged 7 commits into
PowerShell:masterfrom
xtqqczze:RCS-Redundancy-fixes

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Jun 8, 2020

Copy link
Copy Markdown
Contributor

PR Summary

Using selected Roslynator "Redundancy" fixes.

PR Context

PR Checklist

@iSazonov Ilya (iSazonov) added the CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log label Jun 8, 2020
@xtqqczze
xtqqczze force-pushed the RCS-Redundancy-fixes branch from 463f38d to 651eea0 Compare June 8, 2020 09:40
@xtqqczze

xtqqczze commented Jun 8, 2020

Copy link
Copy Markdown
Contributor Author

rebased to remove RCS1032

@iSazonov Ilya (iSazonov) added the AutoMerge informs the bot to automerge the PR label Jun 9, 2020
@ghost

Copy link
Copy Markdown

Hello Ilya (@iSazonov)!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@iSazonov Ilya (iSazonov) added this to the 7.1.0-preview.4 milestone Jun 9, 2020
@xtqqczze

Copy link
Copy Markdown
Contributor Author

Ilya (@iSazonov) It seems the failed Codacy check is preventing automerge.

@iSazonov Ilya (iSazonov) removed the AutoMerge informs the bot to automerge the PR label Jun 11, 2020
@iSazonov
Ilya (iSazonov) merged commit 0d5d017 into PowerShell:master Jun 11, 2020
@xtqqczze
xtqqczze deleted the RCS-Redundancy-fixes branch June 12, 2020 00:52
@ghost

Copy link
Copy Markdown

🎉v7.1.0-preview.4 has been released which incorporates this pull request.:tada:

Handy links:

Thatgfsj (Thatgfsj) pushed a commit to Thatgfsj/PowerShell that referenced this pull request Aug 6, 2026
* Autofix `RCS1036: Remove redundant empty line`

* Autofix `RCS1037: Remove trailing white-space`

* Autofix `RCS1033: Remove redundant boolean literal`

* Autofix: `RCS1038: Remove empty statement`

* Autofix `RCS1041: Remove empty initializer`

* Autofix `RCS1097: Remove redundant 'ToString' call

* Autofix: `RCS1420: Operator is unnecessary`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-CodeCleanup Indicates that a PR should be marked as a Code Cleanup change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants