Skip to content

Update changelog generation script#11736

Merged
6 commits merged intoPowerShell:masterfrom
xtqqczze:feature-changelog-github-compare
Feb 5, 2020
Merged

Update changelog generation script#11736
6 commits merged intoPowerShell:masterfrom
xtqqczze:feature-changelog-github-compare

Conversation

@xtqqczze
Copy link
Copy Markdown
Contributor

@xtqqczze xtqqczze commented Jan 30, 2020 •
edited
Loading

PR Summary

PR Context

Follow-up to #11652

PR Checklist

@ghost ghost assigned TravisEz13 Jan 30, 2020
@xtqqczze xtqqczze mentioned this pull request Jan 30, 2020
Merged
14 tasks
@xtqqczze xtqqczze changed the title [WIP#Feature changelog GitHub compare part2 Update changelog generation script Jan 31, 2020
@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Jan 31, 2020

@TravisEz13 Since this functionality requires an additional parameter ThisReleaseTag I have avoided making changes to Get-ChangeLog. If you would like to to make changes, you could push to this branch on xtqqczze/PowerShell-PowerShell.

@iSazonov iSazonov added the CL-Tools Indicates that a PR should be marked as a tools change in the Change Log label Jan 31, 2020
@iSazonov iSazonov added this to the 7.1.0-preview.1 milestone Jan 31, 2020
TravisEz13
TravisEz13 requested changes Jan 31, 2020
View reviewed changes
Comment thread tools/releaseTools.psm1 Outdated
Comment thread tools/releaseTools.psm1
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Jan 31, 2020
@TravisEz13
Copy link
Copy Markdown
Member

TravisEz13 commented Jan 31, 2020

@adityapatwardhan Should be port this to 7.0?

@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 1, 2020
@xtqqczze xtqqczze requested a review from TravisEz13 February 1, 2020 12:28
TravisEz13
TravisEz13 reviewed Feb 3, 2020
View reviewed changes
Comment thread tools/releaseTools.psm1 Outdated
@TravisEz13
Copy link
Copy Markdown
Member

TravisEz13 commented Feb 3, 2020

@PoshChan Please remind me in 4 hours

@PoshChan
Copy link
Copy Markdown
Collaborator

PoshChan commented Feb 3, 2020

@TravisEz13, this is the reminder you requested 4 hours ago

TravisEz13
TravisEz13 requested changes Feb 3, 2020
View reviewed changes
Comment thread tools/releaseTools.psm1 Outdated
@ghost ghost added the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 3, 2020
@xtqqczze
Make ThisReleaseTag paramter mandatory
dc47396 
Address @ TravisEz13 review
@xtqqczze xtqqczze force-pushed the feature-changelog-github-compare branch from 5278789 to dc47396 Compare February 4, 2020 23:27
@ghost ghost removed the Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept label Feb 4, 2020
@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Feb 4, 2020

PR is ready to merge.

@TravisEz13 TravisEz13 added the AutoMerge informs the bot to automerge the PR label Feb 4, 2020
@ghost
Copy link
Copy Markdown

ghost commented Feb 4, 2020

Hello @TravisEz13!

Because this pull request has the AutoMerge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@TravisEz13 TravisEz13 added AutoMerge informs the bot to automerge the PR and removed AutoMerge informs the bot to automerge the PR labels Feb 5, 2020
@ghost ghost merged commit e2f838e into PowerShell:master Feb 5, 2020
@xtqqczze xtqqczze deleted the feature-changelog-github-compare branch February 6, 2020 09:17
@TravisEz13 TravisEz13 modified the milestones: GA-consider, GA-approved Feb 7, 2020
@TravisEz13 TravisEz13 modified the milestones: GA-approved, 7.0.0 Feb 8, 2020
adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Feb 18, 2020
@xtqqczze @TravisEz13
Update changelog generation script (PowerShell#11736)
f9e0ccc 
# Conflicts:
#	CHANGELOG/6.2.md
@ghost
Copy link
Copy Markdown

ghost commented Feb 21, 2020

🎉v7.0.0-rc.3 has been released which incorporates this pull request.:tada:

Handy links:

@xtqqczze
Copy link
Copy Markdown
Contributor Author

xtqqczze commented Feb 22, 2020

@TravisEz13 Any further improvements to the changelog generation script you think could be made?

@TravisEz13
Copy link
Copy Markdown
Member

TravisEz13 commented Feb 24, 2020

Personally, I think the build and packaging section, should just list the PR numbers and not the description (perhaps thank any non-microsoft contributor).
I like this a lot more now that you have links to the full history.

@TravisEz13
Copy link
Copy Markdown
Member

TravisEz13 commented Feb 24, 2020

Or better yet list it as details, for example

11736 Update changelog generation 
<details>
<summary>11736</summary>
Update changelog generation
</details>

@TravisEz13 TravisEz13 mentioned this pull request Oct 12, 2022
Merged
22 tasks
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TravisEz13 TravisEz13 TravisEz13 approved these changes

@adityapatwardhan adityapatwardhan Awaiting requested review from adityapatwardhan

@anmenaga anmenaga Awaiting requested review from anmenaga

@daxian-dbw daxian-dbw Awaiting requested review from daxian-dbw

Assignees

@TravisEz13 TravisEz13

Labels

AutoMerge informs the bot to automerge the PR CL-Tools Indicates that a PR should be marked as a tools change in the Change Log

Projects

None yet

Milestone

7.0.0-rc.3

Development

Successfully merging this pull request may close these issues.

5 participants

@xtqqczze @TravisEz13 @PoshChan @adityapatwardhan @iSazonov