Skip to content

Update PSReadLine corresponding to the prediction interface update - #2225

Merged
Dongbo Wang (daxian-dbw) merged 6 commits into
PowerShell:masterfrom
daxian-dbw:predict
Feb 23, 2021
Merged

Update PSReadLine corresponding to the prediction interface update#2225
Dongbo Wang (daxian-dbw) merged 6 commits into
PowerShell:masterfrom
daxian-dbw:predict

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Feb 18, 2021

Copy link
Copy Markdown
Member

PR Summary

Fix #2221

Major changes:

  1. Update PSReadLine corresponding to the prediction interface update
    • provide the OnSuggestionDisplayed feedback
    • pass in the client-id PSReadLine, as well as the predictor mini-session id, when providing feedback.
  2. Move to net6.0 and consume PowerShell 7.2.0-preview.3 NuGet packages

PR Checklist

  • PR has a meaningful title
    • Use the present tense and imperative mood when describing your changes
  • Summarized changes
  • Make sure you've added one or more new tests
  • Make sure you've tested these changes in terminals that PowerShell is commonly used in (i.e. conhost.exe, Windows Terminal, Visual Studio Code Integrated Terminal, etc.)
  • User-facing changes
    • Not Applicable
    • OR
    • Documentation needed at PowerShell-Docs
      • Doc Issue filed:
Microsoft Reviewers: Open in CodeFlow

@daxian-dbw
Dongbo Wang (daxian-dbw) marked this pull request as ready for review February 18, 2021 18:51
Comment thread PSReadLine/Prediction.Entry.cs Outdated
Comment thread test/InlinePredictionTest.cs Outdated
Comment thread MockPSConsole/MockPSConsole.csproj
Comment thread test/ListPredictionTest.cs Outdated
@ghost ghost removed the Needs-Author Feedback label Feb 23, 2021
@daxian-dbw

Copy link
Copy Markdown
Member Author

The Aladdin team confirmed that the PSReadLine, PowerShell 7.2.0-preview.3, and Az.Predictor are working as expected end-to-end. I will merge this PR and get ready for the 2.2.0-beta2 release.

@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 8df5b6b into PowerShell:master Feb 23, 2021
@ghost

Copy link
Copy Markdown

🎉 v2.2.0-beta2 has been released which incorporates this pull request. 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PSReadLine doesn't work on 7.2.0-preview.3

4 participants