Skip to content

Add Gen 4 Trades to API - #1640

Open
notblisy wants to merge 5 commits into
PokeAPI:masterfrom
notblisy:G4-In-game-trades
Open

Add Gen 4 Trades to API#1640
notblisy wants to merge 5 commits into
PokeAPI:masterfrom
notblisy:G4-In-game-trades

Conversation

@notblisy

Copy link
Copy Markdown
Contributor

Change description

  • Add all DPPt and HGSS trades
  • Add relevant encounter conditions and prose
  • Add 4 new location areas for trades that didn't exist
  • New min level for trades is 1 now, so instead of 5-100 on "lowest evo" pokemon, it's 1-100.

AI coding assistance disclosure

  • No AI was used in this PR

Contributor check list

  • I have written a description of the contribution and explained its motivation.
  • I have written tests for my code changes (if applicable).
  • I have read and understood the AI Assisted Contribution guidelines.
  • I will own this change in production, and I am prepared to fix any bugs caused by my code change.

Initial commit forgot the HGSS Pokemon and also had a typo causing the build to fail.

@jemarq04 jemarq04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of typos - otherwise looks great!

Comment thread data/v2/csv/encounter_condition_value_prose.csv Outdated
Comment thread data/v2/csv/encounter_condition_values.csv Outdated
notblisy and others added 2 commits August 19, 2026 14:17
Co-authored-by: Justin Marquez <37006684+jemarq04@users.noreply.github.com>
Co-authored-by: Justin Marquez <37006684+jemarq04@users.noreply.github.com>
@notblisy

Copy link
Copy Markdown
Contributor Author

Glad to hear it!

@jemarq04 jemarq04 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants