Conversation
Member
|
@anhthang could you review a little? |
|
@Naramsim The pokemon data is fine to me. I just have concern about the schema, some properties schema changed from |
Member
|
Yeah, I saw! But in the end I don't really think it's a big problem. |
Member
|
Do you think you could provide that data, or it's something that cannot be fetched? |
|
I tried to find that from Bulbapedia, pokemondb but no information. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incoming data generated by PokeAPI/pokeapi's CircleCI worker since Pull Request #721 was merged into the
masterbranch.The new data was generated using a copy of PokeAPI/pokeapi repository when the
HEADwas pointing tod94f7602161b41e8f716272c0a57c1a730523524.This Pull Request should have been deployed in our staging environment, check here for the lastest build timestamp and status code.