Skip to content

Added shaders for drawing a triangle - #18

Closed
iddm wants to merge 1 commit into
Overv:masterfrom
iddm:master
Closed

Added shaders for drawing a triangle#18
iddm wants to merge 1 commit into
Overv:masterfrom
iddm:master

Conversation

@iddm

@iddm iddm commented Aug 1, 2016

Copy link
Copy Markdown

Currently there is no way to compile a code used in "Drawing a triangle" tutorial without creating shaders. I have added shaders to make it possible.

@Overv

Overv commented Aug 1, 2016

Copy link
Copy Markdown
Owner

The shader code is already listed in the Shader Modules chapter.

@iddm

iddm commented Aug 1, 2016

Copy link
Copy Markdown
Author

Yes, it is listed but it is not included in the git repository. So, just to check you installed vulkan correctly and everything works fine on your system and you able to learn vulkan with your website (vulkan-tutorial.com) you need only to compile the code and run it if you merge the PR. Otherwise you need to read everything and just find out something is wrong in the end. Personally, I think it is better to run the example code to see everything is okay BEFORE reading the tutorial part. Also I read the example code on one monitor and tutorial on another which makes understanding easier.

Also, why do you provide example code in the git repository without making it possible to run it? This is meaningless. If someone wants to do everything from scratch with your tutorial - he will do this. If someone wants to run your example code - he does not have that opportunity.

@Overv

Overv commented Aug 1, 2016

Copy link
Copy Markdown
Owner

The Development environment chapter already includes all the instructions and code you need to check if Vulkan is working. If the samples in there are working, then you will not run into any surprises during the main tutorials.

You have misunderstood the purpose of the example code. The example code is there for if you get stuck somewhere in the tutorial, for example if you are unsure how to organise a function. It is not there for people who just want to run Vulkan demos. That's what these demos are for.

@Overv

Overv commented Feb 16, 2017

Copy link
Copy Markdown
Owner

Shaders have been included now.

@Overv Overv closed this Feb 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants