feign.Request object now supported as exception constructor parameter#23
feign.Request object now supported as exception constructor parameter#23saintf merged 2 commits intoOpenFeign:masterfrom
Conversation
The ExceptionGenerator now * also looks for constructor parameter of type feign.Request. * creates the exception providing the feign.Request by calling response.request()
|
Hey @saintf, i've two questions: First, is this pull request fine for you? And second most important for me, when do you plan to release? Best regards, Stefan |
|
Hey @saintf , how are you? I would be happy if you tell me some time horizon i can calculate with getting a new version including my pull request :-) Have a good time, Stefan |
|
Sorry Stefan!! Work and personal life have been brutal. I'll look at it
this weekend and if all good I'll release it then. Sorry it took me so
long!!!
…On Wed, 17 Jul 2019, 18:30 StefanFellinger, ***@***.***> wrote:
Hey @saintf <https://github.com/saintf> ,
how are you? I would be happy if you tell me some time horizon i can
calculate with getting a new version including my pull request :-)
Have a good time,
Stefan
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#23?email_source=notifications&email_token=ADJ2TCWULRFSD4V5KMAFESDP75CIVA5CNFSM4HYQRYIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2E65VA#issuecomment-512356052>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADJ2TCULMIKGIR6SONLEXODP75CIVANCNFSM4HYQRYIA>
.
|
|
Hey @saintf , oh i know, luckily i "only" have a bit of water in one of my cellar rooms, comming from somewhere outside. Now i have a new hobby: finding the source of water leaking. Most important family and friends are all healthy. So we actually work on a project replacing some legacy systems, so i have many items on my todos list. |
|
Code looks good. thanks for paying attention to style and covering with tests (much much appreciated ;)). I've merged - and will release shortly. |
The ExceptionGenerator now