Skip to content

Fixes the case where response decoders were unable to parse the type.#21

Merged
saintf merged 6 commits intoOpenFeign:masterfrom
SimY4:master
May 29, 2019
Merged

Fixes the case where response decoders were unable to parse the type.#21
saintf merged 6 commits intoOpenFeign:masterfrom
SimY4:master

Conversation

@SimY4
Copy link
Copy Markdown
Contributor

@SimY4 SimY4 commented Apr 15, 2019

Two things were addressed here:

  1. Raw response object injection.
  2. Generic type information was lost during decoder delegation and decoders were unable to figure out which result type was expected.

@saintf
Copy link
Copy Markdown
Collaborator

saintf commented May 28, 2019

@SimY4 this looks quite good. The only problem you have (and the reason the build fails) is on codestyle on the test. If you run the build locally, you'll see it formats it automatically and hence there's a difference (and hence it is not ready for merging). Can you fix that formatting and I can then merge the pull request. Happy to release it after that.

@saintf
Copy link
Copy Markdown
Collaborator

saintf commented May 28, 2019

@SimY4 - I merged your changes into my fork and made the formatting changes (you potentially have to skip gpg signing if you want it to work correctly - depending on your setup).

I created a pull request into your fork for the changes so you can use them and update this PR:
https://github.com/SimY4/feign-annotation-error-decoder/pull/1

Once the changes are made it will allow me to easily merge and release.

minor formatting changes to let build succeed
@SimY4
Copy link
Copy Markdown
Contributor Author

SimY4 commented May 28, 2019

@saintf good to go

Thanks again for reviewing this PR.

@saintf saintf merged commit dd5a316 into OpenFeign:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants