Skip to content

Remove feign-example-github dependency from apt-test-generator#3246

Merged
velo merged 1 commit intomasterfrom
fix/apt-test-generator-deploy
Feb 26, 2026
Merged

Remove feign-example-github dependency from apt-test-generator#3246
velo merged 1 commit intomasterfrom
fix/apt-test-generator-deploy

Conversation

@velo
Copy link
Copy Markdown
Member

@velo velo commented Feb 26, 2026

Summary

  • Deploy fails because feign-apt-test-generator has a test-scoped dependency on feign-example-github, which is excluded from the reactor during deploy. Maven still resolves test dependencies even with -DskipTests=true, so the SNAPSHOT jar can't be found.
  • Internalizes the test fixtures by copying GitHubExample.java and moving GitHubStub.java into src/test/resources/ (used as APT input and golden file, not compiled by Maven)
  • Replaces the feign-example-github dependency with feign-core + feign-gson (published modules that are always resolvable)

Test plan

  • mvn clean test -pl apt-test-generator -am passes
  • mvn dependency:resolve -pl apt-test-generator resolves without feign-example-github
  • Full reactor build passes (excluding pre-existing jaxrs3/jaxrs4 failures)

… deploy

Signed-off-by: Marvin Froeder <velo.br@gmail.com>
@velo velo merged commit 1acb3ce into master Feb 26, 2026
4 checks passed
@velo velo deleted the fix/apt-test-generator-deploy branch February 26, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant