Headers substitutions were not being expanded by the value name#161
Merged
codefromthecrypt merged 1 commit intoOpenFeign:masterfrom Feb 4, 2015
Merged
Headers substitutions were not being expanded by the value name#161codefromthecrypt merged 1 commit intoOpenFeign:masterfrom
codefromthecrypt merged 1 commit intoOpenFeign:masterfrom
Conversation
…ead it was using the header name..
|
NetflixOSS » feign » feign-pull-requests #45 SUCCESS |
Contributor
|
whoops. thanks for the fix! |
codefromthecrypt
pushed a commit
that referenced
this pull request
Feb 4, 2015
Headers substitutions were not being expanded by the value name
Contributor
|
when I get home, I'll cherry-pick into 7.x we should collect any other bugs you, others, or I pickup prior to cutting 7.2.1 maybe timeout of next mondayish. |
Contributor
Author
|
this is actually blocking us right now.. is it possible to release it sooner? |
Closed
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Headers substitutions were not being expanded by the value name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Header params were using the header name instead of the value.
So if you had:
It was looking up by 'Auth-Token' instead of 'authToken' so it wouldn't substitute the value in 'token' above.