Skip to content
This repository was archived by the owner on Jun 18, 2024. It is now read-only.

Ewsxmlreaderfix - #337

Closed
Onur Atamer (atamer) wants to merge 2 commits into
OfficeDev:masterfrom
atamer:ewsxmlreaderfix
Closed

Ewsxmlreaderfix#337
Onur Atamer (atamer) wants to merge 2 commits into
OfficeDev:masterfrom
atamer:ewsxmlreaderfix

Conversation

@atamer

@atamer Onur Atamer (atamer) commented Jun 2, 2015

Copy link
Copy Markdown
Contributor

I got the following exception when the subject of one email subject is : =?iso-8859-1?Q?=00?=
and empty appointments got the same error, I think it is also a solution to #262

microsoft.exchange.webservices.data.EWSHttpException: Connection not established
     at microsoft.exchange.webservices.data.HttpClientWebRequest.throwIfConnIsNull(Unknown Source)
     at microsoft.exchange.webservices.data.HttpClientWebRequest.getResponseHeaders(Unknown Source)
     at microsoft.exchange.webservices.data.ExchangeServiceBase.processHttpResponseHeaders(Unknown Source)
     at microsoft.exchange.webservices.data.SimpleServiceRequestBase.internalExecute(Unknown Source)
     at microsoft.exchange.webservices.data.MultiResponseServiceRequest.execute(Unknown Source)
     at microsoft.exchange.webservices.data.ExchangeService.findItems(Unknown Source)
     at microsoft.exchange.webservices.data.ExchangeService.findItems(Unknown Source)

@azurecla

Azure Contribution License Agreements (azurecla) commented Jun 2, 2015

Copy link
Copy Markdown

Hi Onur Atamer (@atamer), I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!
We will now validate the agreement and then real humans will evaluate your PR.

TTYL, AZPRBOT;

@atamer Onur Atamer (atamer) mentioned this pull request Jun 2, 2015
Open
@serious6

André (serious6) commented Jun 2, 2015

Copy link
Copy Markdown
Member

Onur Atamer (@atamer) looks ok. Please squash the two commits to a single one and also add some unit-tests for the parsing process.

@serious6

André (serious6) commented Jun 5, 2015

Copy link
Copy Markdown
Member

Onur Atamer (@atamer) are you planing any changes here?

@serious6 André (serious6) mentioned this pull request Jun 16, 2015
Open
@vboctor

Victor Boctor (vboctor) commented Jun 16, 2015

Copy link
Copy Markdown
Contributor

I'm unable to see the exact fix in the code. There is a lot of styling changes in this change. Let's make sure that we have a targeted fix.

Are we saying that "data" within an object can break our xml parser? I would like the library to break when the envelope XML returned by the service is broken. However, it shouldn't break if the data has complete non-sense. Are we doing the right escaping?

@serious6

André (serious6) commented Jun 25, 2015

Copy link
Copy Markdown
Member

Onur Atamer (@atamer) plz remove the unecessary commits. If you dont I will create another PR of this. With only the small change left.

@serious6 André (serious6) mentioned this pull request Jul 7, 2015
Merged
@serious6

André (serious6) commented Jul 7, 2015

Copy link
Copy Markdown
Member

Thanks Onur Atamer (@atamer) opened #364 with only the significant contribution.

dwissk added a commit to ebf/ews-java-api that referenced this pull request May 12, 2017
@dwissk
attempt to fix Could not read value from END_ELEMENT. Could not find …
57234d0 
…CHARACTERS CXSRV-1114 #done

https://ebf-dev.atlassian.net/browse/CXSRV-1114
OfficeDev#262
OfficeDev#337
OfficeDev#364
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@atamer @azurecla @serious6 @vboctor