fix(dockerfile): deprecated Dockerfile instructions - #230
Merged
Conversation
Contributor
|
@darkspirit510 - Do you have any time to test this and let me know if you think we should merge it? |
Contributor
|
@davewichers this can be merged. The Dockerfile is fine, but the build is broken (because of this line, not an issue of this PR). |
Contributor
|
@darkspirit510 - What do you mean the 'build is broken'? In Docker, or ??? I suspect the version of Java in the Docker container needs to be upgraded to Java 17 and maybe that will fix it? I had to do something similar in this commit: 2cf91fa. Actually, this has already been fixed by: b74c1df so I merged this and am building the new Docker image so I can publish it now. |
Contributor
|
@davewichers yes, I meant the Java 17 update, did not see this merge. So it's fine 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the two warnings in the image below while building the Docker image
