Skip to content

Protect MemoryHandler alias with a namespace#442

Merged
pelesh merged 1 commit into
developfrom
slaven/memory-utils-fix
Jul 11, 2026
Merged

Protect MemoryHandler alias with a namespace#442
pelesh merged 1 commit into
developfrom
slaven/memory-utils-fix

Conversation

@pelesh

@pelesh pelesh commented Jul 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Description

Protect MemoryHandler alias with ReSolve namespace.

Proposed changes

MemoryHandler was placed in global namespace by accident. Now it is within ReSolve namespace.

Checklist

  • All tests pass (make test and make test_install per testing instructions). Code tested on
    • CPU backend
    • CUDA backend
    • HIP backend
  • N/A (see Bug: Recent commits broke Re::Solve examples #444) I have manually run the non-experimental examples and verified that residuals are close to machine precision. (In your build directory run: ./examples/<your_example>.exe -h to get instructions how to run examples). Code tested on:
    • CPU backend
    • CUDA backend
    • HIP backend
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows Re::Solve style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • N/A I have updated CHANGELOG.md to reflect the changes in this PR. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

@pelesh pelesh self-assigned this Jul 11, 2026
@pelesh pelesh added the bug Something isn't working label Jul 11, 2026
@pelesh pelesh added this to the Release 0.99.3 milestone Jul 11, 2026
@alexander-novo

alexander-novo commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Does MemoryHandler not get consumed by anything in the code base? Is it just for users' sake?

@pelesh

pelesh commented Jul 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Does MemoryHandler not get consumed by anything in the code base? Is it just for users' sake?

It is used in workspaces, matrix/vector classes and handlers, and everywhere else where memory management, including host-device transfers is required. It is not supposed to be exposed to the users.

@alexander-novo

alexander-novo commented Jul 11, 2026

Copy link
Copy Markdown
Collaborator

Ah okay but all this stuff is already in the correct namespace so they didn’t need to be changed. Makes sense.

@pelesh pelesh merged commit bd60de0 into develop Jul 11, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alexander-novo alexander-novo alexander-novo approved these changes
@shakedregev shakedregev Awaiting requested review from shakedregev

Assignees

@pelesh pelesh

Labels

bug Something isn't working

Projects

None yet

Milestone

Release 0.99.3

Development

Successfully merging this pull request may close these issues.

2 participants

@pelesh @alexander-novo