Skip to content

Only add typing requirement if python version is <3.5 - #101

Merged
Kalebu merged 1 commit into
Neurotech-HQ:mainfrom
leoparente:main
Nov 24, 2023
Merged

Only add typing requirement if python version is <3.5#101
Kalebu merged 1 commit into
Neurotech-HQ:mainfrom
leoparente:main

Conversation

@leoparente

Copy link
Copy Markdown
Contributor

I'm having some issues in AWS with this package.

this change is a recommendation from the package maintainers: https://pypi.org/project/typing/

For package maintainers, it is preferred to use typing;python_version<"3.5" if your package requires it to support earlier Python versions. This will avoid shadowing the stdlib typing module when your package is installed via pip install -t . on Python 3.5 or later.

and I also saw this setup change in another project: hardbyte/python-can#452

@Kalebu
Kalebu merged commit 2f7fc8b into Neurotech-HQ:main Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants