Skip to content

Add update_settings and channel_changed functions - #20

Merged
Claybarn merged 7 commits into
NeuroNetMem:masterfrom
markschatza:update-settings
Jun 8, 2019
Merged

Add update_settings and channel_changed functions#20
Claybarn merged 7 commits into
NeuroNetMem:masterfrom
markschatza:update-settings

Conversation

@ethanbb

@ethanbb ethanbb commented Jun 6, 2019

Copy link
Copy Markdown
Contributor

This resolves #10 by allowing Python modules to react when the number of channels, sample rate, and/or set of selected channels changes. The new update_settings function receives the number of channels and sample rate whenever updateSettings is called in the C++ plugin, and channel_changed is called whenever the editor's channelChanged function gets called.

Other things:

  • The Cython compiler was interpreting plugins as Python 2 rather than 3 (I believe due to one of my earlier PRs - sorry), so I changed all the setup.py files to fix that.
  • Added the resetPlugin function to make it so that the function pointers are always null unless there is a plugin loaded. I'm thinking this could be useful in a future PR to allow unloading plugins.

@Claybarn
Claybarn merged commit 4494ede into NeuroNetMem:master Jun 8, 2019
@ethanbb
ethanbb deleted the update-settings branch June 10, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sample rate passed to plugin startup() is NOT the data sampling rate

3 participants