Remove option to build with external startup data, and tools builds - #2
Merged
Merged
Conversation
The automatic exportation of environment variables based on the config key in package.json was removed in later versions of Node.js. Here, we manually set the environment variable if it's not automatically set.
Ninja is a prerequisite for the build. On Ubuntu install it with apt-get, and on GitHub's macOS Docker image it needs to come from Homebrew.
This makes V8 always build with v8_use_external_startup_data=false. Since that was previously controlled by the EXTERNAL_STARTUP_DATA variable, we can remove that variable. If we're not using external startup heap snapshots, we also don't need to export mksnapshot and mkcodecache; they are now only used internally by the V8 build. This also makes a TOOLS_ONLY build and therefore a tools_macos_android build obsolete. Summary: - Remove EXTERNAL_STARTUP_DATA - Remove TOOLS_ONLY - Remove MKSNAPSHOT_ONLY - Remove MKCODECACHE_ONLY - Remove patch to allow monolithic build with external startup data - Remove patch to export mkcodecache - Remove tools_macos_android workflow
Collaborator
Author
|
Updated: Removed some additional things I found, that were related to macos_tools builds. |
This was referenced May 4, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per NativeScript/NativeScript#8926, it's no longer necessary to support configuring V8 with support for external startup data. We can set this option to always be false. With no external startup data, we also don't need to export the
mksnapshottool, as it will now only be used internally by V8 during the build.It seems that we don't need
mkcodecacheeither, although I'm not 100% sure about this — please let me know if it is used for something.If we need neither of
mksnapshotandmkcodecache, then we don't need a tools-only build either.If accepted, the commits in this PR should be cherry-picked to the other branches — at least the other 3 Android branches, though I don't think it could hurt to port them to the iOS branches as well. Let me know if I should open separate PRs for this.