fix(ios): no blurred images in image picker - #211
Conversation
fix for displaying blurred images in image picker when the root view of the app is any layout nesting TabView related to NativeScript#195
|
The CI build for this PR failed because the changed code references "tns-core-modules": "^3.1.0",
"tns-platform-declarations": "^3.1.0",You should either update the references in package.json or make the code work without them. The error at the moment is: $ tsc
imagepicker.ios.ts:31:46 - error TS2339: Property 'viewController' does not exist on type 'View'.
31 return this.hostView ? this.hostView.viewController : UIApplication.sharedApplication.keyWindow.rootViewController;
~~~~~~~~~~~~~~ |
|
Can I make a test CI build myself? |
|
The CI is public and you can view the results by going directly to https://travis-ci.org/NativeScript/nativescript-imagepicker/pull_requests |
Updated tns dependencies versions to 4.0.0
|
Ok, so I fixed package.json versions but now there are errors during UI tests... Any hints how to fix them? |
|
@JakubPawlak Unfortunately, our tests use env variables that are not exposed by PR made from forks https://docs.travis-ci.com/user/pull-requests#pull-requests-and-security-restrictions. I will test your branch and merge it manually. |
Fix for displaying blurred images in image picker when the root view of the app is any layout nesting TabView.
Branch on which there is a reproduced bad behaviour is here:
https://github.com/JakubPawlak/nativescript-imagepicker/tree/blur
PR Checklist
What is the current behavior?
In some specific cases, image picker is showing blurred images.
#195
What is the new behavior?
No blurred images.
Fixes #195
No migration steps.