Skip to content

Remove defunct V8 external startup data stuff #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NathanWalker merged 3 commits into from
May 4, 2023
Merged

Remove defunct V8 external startup data stuff #210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fbdc56
chore: Remove unused snapshot blob member
ptomato Apr 18, 2023
5f41141
chore: Remove SnapshotBlob.h from project file
ptomato Apr 19, 2023
cc6c991
chore: Instructions for installing xcodeproj/cococapods in readme
ptomato Apr 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion NativeScript/v8runtime/V8Runtime.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,6 @@ class V8Runtime : public facebook::jsi::Runtime {

private:
std::unique_ptr<v8::ArrayBuffer::Allocator> arrayBufferAllocator_;
std::unique_ptr<v8::StartupData> snapshotBlob_;
v8::Isolate *isolate_;
v8::Global<v8::Context> context_;
bool isSharedRuntime_ = false;
Expand Down
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ git submodule update --init
# Ensure that you have the required llvm binaries for building the metadata generator
./download_llvm.sh

sudo gem install xcodeproj
sudo gem install cocoapods

# Open the runtime in Xcode
open v8ios.xcodeproj
```
Expand Down
4 changes: 0 additions & 4 deletions v8ios.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
/* Begin PBXBuildFile section */
2B7EA6AF2353477000E5184E /* NativeScriptException.mm in Sources */ = {isa = PBXBuildFile; fileRef = 2B7EA6AD2353476F00E5184E /* NativeScriptException.mm */; };
2B7EA6B02353477000E5184E /* NativeScriptException.h in Headers */ = {isa = PBXBuildFile; fileRef = 2B7EA6AE2353477000E5184E /* NativeScriptException.h */; };
2C998AC1290FB501002BBFA9 /* SnapshotBlob.h in Headers */ = {isa = PBXBuildFile; fileRef = 2C998AC0290FB500002BBFA9 /* SnapshotBlob.h */; };
3CA6E53529A78C6000D30F8B /* IsolateWrapper.h in Headers */ = {isa = PBXBuildFile; fileRef = 3CA6E53429A78C6000D30F8B /* IsolateWrapper.h */; };
3CBFF7442971C1C200C5DE36 /* ArcMacro.h in Headers */ = {isa = PBXBuildFile; fileRef = 3CBFF7432971C1C200C5DE36 /* ArcMacro.h */; };
3CD1D9C129AA2C14004C1C21 /* DisposerPHV.mm in Sources */ = {isa = PBXBuildFile; fileRef = 3CD1D9BF29AA2C14004C1C21 /* DisposerPHV.mm */; };
Expand Down Expand Up @@ -418,7 +417,6 @@
/* Begin PBXFileReference section */
2B7EA6AD2353476F00E5184E /* NativeScriptException.mm */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.objcpp; path = NativeScriptException.mm; sourceTree = "<group>"; };
2B7EA6AE2353477000E5184E /* NativeScriptException.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = NativeScriptException.h; sourceTree = "<group>"; };
2C998AC0290FB500002BBFA9 /* SnapshotBlob.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = SnapshotBlob.h; sourceTree = "<group>"; };
3CA6E53429A78C6000D30F8B /* IsolateWrapper.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = IsolateWrapper.h; sourceTree = "<group>"; };
3CBFF7432971C1C200C5DE36 /* ArcMacro.h */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.c.h; path = ArcMacro.h; sourceTree = "<group>"; };
3CD1D9BF29AA2C14004C1C21 /* DisposerPHV.mm */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.cpp.objcpp; path = DisposerPHV.mm; sourceTree = "<group>"; };
Expand Down Expand Up @@ -1407,7 +1405,6 @@
C275F475253B37AB00A997D5 /* UnmanagedType.mm */,
3CEF9CCC28F896B70056BA45 /* SpinLock.h */,
3CA6E53429A78C6000D30F8B /* IsolateWrapper.h */,
2C998AC0290FB500002BBFA9 /* SnapshotBlob.h */,
);
path = runtime;
sourceTree = "<group>";
Expand Down Expand Up @@ -1498,7 +1495,6 @@
C2D7E9D523F42C1100DB289C /* PromiseProxy.h in Headers */,
C2A5F86B2359AEB600074AFA /* ExtVector.h in Headers */,
C2DDEBB0229EAC8300345BFE /* StringHasher.h in Headers */,
2C998AC1290FB501002BBFA9 /* SnapshotBlob.h in Headers */,
C247C16A22F82842001D2CA2 /* v8-profiler.h in Headers */,
C2DDEB8E229EAC8300345BFE /* Interop.h in Headers */,
C2DDEBA2229EAC8300345BFE /* Console.h in Headers */,
Expand Down