Fix for frequent crashes in Frame package#5063
Closed
DickSmith wants to merge 11 commits intoNativeScript:masterfrom
DickSmith:master
Closed
Fix for frequent crashes in Frame package#5063DickSmith wants to merge 11 commits intoNativeScript:masterfrom DickSmith:master
DickSmith wants to merge 11 commits intoNativeScript:masterfrom
DickSmith:master
Conversation
|
Can one of the admins verify this patch? |
Contributor
There was a problem hiding this comment.
This is critical issue and has caused many crashers on iOS and Android with NativeScript for Angular stack. In general more guards like this would help prevent unnecessary app crashers for everyone.
Thank you @DickSmith for posting this fix. @vakrilov @vchimev would be excellent to see this in on next builds soon 👍
added 3 commits
November 12, 2017 22:45
…ersion to my users, I also noticed a few of these as well: ``` com.tns.NativeScriptException: Calling js method run failed TypeError: Cannot read property 'navDepth' of undefined File: "file:///data/data/__REDACTED__/files/app/vendor.js, line: 1, column: 1281638 StackTrace: Frame: function:'t._goBackCore', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 451275 Frame: function:'r.performGoBack', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1165482 Frame: function:'r._processNavigationContext', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1164863 Frame: function:'t._processNavigationContext', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 454543 Frame: function:'r._processNavigationQueue', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1164163 Frame: function:'t.setCurrent', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 449995 Frame: function:'', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1739072 Frame: function:'e.invokeTask', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1286901 Frame: function:'f.runTask', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1282022 Frame: function:'invoke', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1287880 Frame: function:'n', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1303661 Frame: function:'u', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 905520 Frame: function:'e.invoke', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1286200 Frame: function:'f.runGuarded', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1281566 Frame: function:'', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 1281183 Frame: function:'run', file:'file:///data/data/__REDACTED__/files/app/vendor.js', line: 1, column: 905605 ```
Exception com.tns.NativeScriptException: Calling js method run failed Error: java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState android.app.FragmentManagerImpl.checkStateLoss(FragmentManager.java:1438) android.app.FragmentManagerImpl.enqueueAction(FragmentManager.java:1456) android.app.BackStackRecord.commitInternal(BackStackRecord.java:707) android.app.BackStackRecord.commit(BackStackRecord.java:671) com.tns.Runtime.callJSMethodNative(Native Method) com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1088) com.tns.Runtime.callJSMethodImpl(Runtime.java:970) com.tns.Runtime.callJSMethod(Runtime.java:957) com.tns.Runtime.callJSMethod(Runtime.java:941) com.tns.Runtime.callJSMethod(Runtime.java:933) [REDACTED_DOMAIN_NAME](Runnable.java:10) android.os.Handler.handleCallback(Handler.java:751) android.os.Handler.dispatchMessage(Handler.java:95) android.os.Looper.loop(Looper.java:154) android.app.ActivityThread.main(ActivityThread.java:6692) java.lang.reflect.Method.invoke(Native Method) com.android.internal.os.ZygoteInit$[REDACTED_DOMAIN_NAME](ZygoteInit.java:1468) com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1358) File: "file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js, line: 1, column: 1284818 StackTrace: Frame: function:'t._navigateCore', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 451777 Frame: function:'r.performNavigation', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1168391 Frame: function:'r._processNavigationContext', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1168070 Frame: function:'t._processNavigationContext', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 455138 Frame: function:'r._processNavigationQueue', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1167343 Frame: function:'t.setCurrent', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 450583 Frame: function:'', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1743837 Frame: function:'e.invokeTask', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1290081 Frame: function:'f.runTask', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1285202 Frame: function:'invoke', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1291060 Frame: function:'n', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1306841 Frame: function:'u', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 901375 Frame: function:'e.invoke', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1289380 Frame: function:'f.runGuarded', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1284746 Frame: function:'', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1284363 Frame: function:'run', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 901460 com.tns.Runtime.callJSMethodNative (Runtime.java) com.tns.Runtime.dispatchCallJSMethodNative (Runtime.java:1088) com.tns.Runtime.callJSMethodImpl (Runtime.java:970) com.tns.Runtime.callJSMethod (Runtime.java:957) com.tns.Runtime.callJSMethod (Runtime.java:941) com.tns.Runtime.callJSMethod (Runtime.java:933) com.tns.gen.java.lang.Runnable.run (Runnable.java:10) android.os.Handler.handleCallback (Handler.java:751) android.os.Handler.dispatchMessage (Handler.java:95) android.os.Looper.loop (Looper.java:154) android.app.ActivityThread.main (ActivityThread.java:6692) java.lang.reflect.Method.invoke (Method.java) com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1468) com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1358) arrow_drop_down Caused by java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState android.app.FragmentManagerImpl.checkStateLoss (FragmentManager.java:1438) android.app.FragmentManagerImpl.enqueueAction (FragmentManager.java:1456) android.app.BackStackRecord.commitInternal (BackStackRecord.java:707) android.app.BackStackRecord.commit (BackStackRecord.java:671) com.tns.Runtime.callJSMethodNative (Runtime.java) com.tns.Runtime.dispatchCallJSMethodNative (Runtime.java:1088) com.tns.Runtime.callJSMethodImpl (Runtime.java:970) com.tns.Runtime.callJSMethod (Runtime.java:957) com.tns.Runtime.callJSMethod (Runtime.java:941) com.tns.Runtime.callJSMethod (Runtime.java:933) com.tns.gen.java.lang.Runnable.run (Runnable.java:10) android.os.Handler.handleCallback (Handler.java:751) android.os.Handler.dispatchMessage (Handler.java:95) android.os.Looper.loop (Looper.java:154) android.app.ActivityThread.main (ActivityThread.java:6692) java.lang.reflect.Method.invoke (Method.java) com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1468) com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1358) ======================================================================================================================= ======================================================================================================================= ======================================================================================================================= Exception com.tns.NativeScriptException: Calling js method run failed Error: java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState android.app.FragmentManagerImpl.checkStateLoss(FragmentManager.java:1438) android.app.FragmentManagerImpl.enqueueAction(FragmentManager.java:1456) android.app.BackStackRecord.commitInternal(BackStackRecord.java:707) android.app.BackStackRecord.commit(BackStackRecord.java:671) com.tns.Runtime.callJSMethodNative(Native Method) com.tns.Runtime.dispatchCallJSMethodNative(Runtime.java:1088) com.tns.Runtime.callJSMethodImpl(Runtime.java:970) com.tns.Runtime.callJSMethod(Runtime.java:957) com.tns.Runtime.callJSMethod(Runtime.java:941) com.tns.Runtime.callJSMethod(Runtime.java:933) [REDACTED_DOMAIN_NAME](Runnable.java:10) android.os.Handler.handleCallback(Handler.java:751) android.os.Handler.dispatchMessage(Handler.java:95) android.os.Looper.loop(Looper.java:154) android.app.ActivityThread.main(ActivityThread.java:6692) java.lang.reflect.Method.invoke(Native Method) com.android.internal.os.ZygoteInit$[REDACTED_DOMAIN_NAME](ZygoteInit.java:1468) com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1358) File: "file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js, line: 1, column: 1284818 StackTrace: Frame: function:'t._goBackCore', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 452207 Frame: function:'r.performGoBack', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1168662 Frame: function:'r._processNavigationContext', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1168043 Frame: function:'t._processNavigationContext', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 455138 Frame: function:'r._processNavigationQueue', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1167343 Frame: function:'t.setCurrent', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 450583 Frame: function:'', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1743837 Frame: function:'e.invokeTask', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1290081 Frame: function:'f.runTask', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1285202 Frame: function:'invoke', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1291060 Frame: function:'n', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1306841 Frame: function:'u', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 901375 Frame: function:'e.invoke', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1289380 Frame: function:'f.runGuarded', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1284746 Frame: function:'', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1284363 Frame: function:'run', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 901460 com.tns.Runtime.callJSMethodNative (Runtime.java) com.tns.Runtime.dispatchCallJSMethodNative (Runtime.java:1088) com.tns.Runtime.callJSMethodImpl (Runtime.java:970) com.tns.Runtime.callJSMethod (Runtime.java:957) com.tns.Runtime.callJSMethod (Runtime.java:941) com.tns.Runtime.callJSMethod (Runtime.java:933) com.tns.gen.java.lang.Runnable.run (Runnable.java:10) android.os.Handler.handleCallback (Handler.java:751) android.os.Handler.dispatchMessage (Handler.java:95) android.os.Looper.loop (Looper.java:154) android.app.ActivityThread.main (ActivityThread.java:6692) java.lang.reflect.Method.invoke (Method.java) com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1468) com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1358) arrow_drop_down Caused by java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState android.app.FragmentManagerImpl.checkStateLoss (FragmentManager.java:1438) android.app.FragmentManagerImpl.enqueueAction (FragmentManager.java:1456) android.app.BackStackRecord.commitInternal (BackStackRecord.java:707) android.app.BackStackRecord.commit (BackStackRecord.java:671) com.tns.Runtime.callJSMethodNative (Runtime.java) com.tns.Runtime.dispatchCallJSMethodNative (Runtime.java:1088) com.tns.Runtime.callJSMethodImpl (Runtime.java:970) com.tns.Runtime.callJSMethod (Runtime.java:957) com.tns.Runtime.callJSMethod (Runtime.java:941) com.tns.Runtime.callJSMethod (Runtime.java:933) com.tns.gen.java.lang.Runnable.run (Runnable.java:10) android.os.Handler.handleCallback (Handler.java:751) android.os.Handler.dispatchMessage (Handler.java:95) android.os.Looper.loop (Looper.java:154) android.app.ActivityThread.main (ActivityThread.java:6692) java.lang.reflect.Method.invoke (Method.java) com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1468) com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1358)
added 3 commits
November 30, 2017 12:30
```Exception com.tns.NativeScriptException: Calling js method run failed TypeError: Cannot read property 'getFragmentManager' of undefined File: "file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js, line: 1, column: 1290524 StackTrace: Frame: function:'t._goBackCore', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 452769 Frame: function:'r.performGoBack', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1174368 Frame: function:'r._processNavigationContext', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1173749 Frame: function:'t._processNavigationContext', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 456009 Frame: function:'r.goBack', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1172002 Frame: function:'t.back', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 589098 Frame: function:'e.back', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 471495 Frame: function:'', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 216780 Frame: function:'u', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 912894 Frame: function:'e.invoke', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1295086 Frame: function:'f.runGuarded', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1290452 Frame: function:'', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 1290069 Frame: function:'run', file:'file:///data/data/com.ugroupmedia.pnp14/files/app/vendor.js', line: 1, column: 912979 com.tns.Runtime.callJSMethodNative (Runtime.java) com.tns.Runtime.dispatchCallJSMethodNative (Runtime.java:1088) com.tns.Runtime.callJSMethodImpl (Runtime.java:970) com.tns.Runtime.callJSMethod (Runtime.java:957) com.tns.Runtime.callJSMethod (Runtime.java:941) com.tns.Runtime.callJSMethod (Runtime.java:933) com.tns.gen.java.lang.Runnable.run (Runnable.java:10) android.os.Handler.handleCallback (Handler.java:751) android.os.Handler.dispatchMessage (Handler.java:95) android.os.Looper.loop (Looper.java:154) android.app.ActivityThread.main (ActivityThread.java:6692) java.lang.reflect.Method.invoke (Method.java) com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run (ZygoteInit.java:1468) com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1358)```
…hinted issues in iOS crash logs
Contributor
|
testsappng |
Contributor
|
uitests |
Contributor
|
testsappng |
added 3 commits
December 8, 2017 00:07
EXC_BAD_ACCESS KERN_INVALID_ADDRESS 0x00000000deaddead keyboard_arrow_up arrow_right 0 NativeScript NativeScript::reportFatalErrorBeforeShutdown(JSC::ExecState*, JSC::Exception*, bool) + 1544 1 NativeScript NativeScript::FFICallback<NativeScript::ObjCMethodCallback>::ffiClosureCallback(ffi_cif*, void*, void**, void*) + 104 2 NativeScript ffi_closure_SYSV_inner + 948 3 NativeScript .Ldo_closure + 20 4 UIKit -[UIGestureRecognizer _touchesEnded:withEvent:] + 168 5 UIKit __55-[UIGestureEnvironment _updateGesturesForEvent:window:]_block_invoke + 708 6 UIKit -[UIGestureEnvironment _deliverEvent:toGestureRecognizers:usingBlock:] + 240 7 UIKit -[UIGestureEnvironment _updateGesturesForEvent:window:] + 276 8 UIKit -[UIWindow sendEvent:] + 3180 9 UIKit -[UIApplication sendEvent:] + 340 10 UIKit __dispatchPreprocessedEventFromEventQueue + 2364 11 UIKit __handleEventQueueInternal + 4760 12 UIKit __handleHIDEventFetcherDrain + 152 13 CoreFoundation __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ + 24
This reverts commit 2d50158.
Contributor
|
@NathanWalker This PR #5173 should resolve all issues with navigation and application suspend/resume. I'm closing this PR. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am getting this reported thousands of times in my crash reporter, so thought I might add in the guards.