fix: dont add to parent from _setupAsRootView - #10554
Merged
Merged
Conversation
NathanWalker
approved these changes
Jun 28, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases you might want to set a parent(mostly rootView) before
_setupAsRootViewso that the the view calling_setupAsRootViewinherits CSS variables and classes from the parent.This is especially done in plugins like bottomsheet or dialogs or popover.
The issue is that if you set parent before
_setupAsRootViewthen_addViewToNativeVisualTreewill be called which could break things like it does with RadSideDrawer nativescript-community/ui-material-components#462.This PR fixes that by just preventing
_addViewToNativeVisualTreeto be called from_setupAsRootViewwhich makes sense to me.PR Checklist
What is the current behavior?
What is the new behavior?
Fixes/Implements/Closes #[Issue Number].