fix: Bind inherited MCP credentials to configured REST origin#3501
fix: Bind inherited MCP credentials to configured REST origin#3501kfelternv wants to merge 3 commits into
Conversation
Signed-off-by: Kyle Felter <kfelter@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-07-14 23:19:06 UTC | Commit: 43983c5 |
🔍 Container Scan Summary
Per-CVE detail lives in the per-service |
What this PR does
Ports the MCP credential-origin binding fix to
release/v2.0.How we verified it
Revision:
43983c5a22dd681f467d6368475b6cb898a5eca3Environment: macOS 26.5.1 on arm64 with Go 1.26.4. The actual
nico-mcpbinary was built from this release PR and exercised over real localhost HTTP connections.Before the two follow-up commits, revision
aa3832b227435fc4f9b7464248ca92b94403a0cbrejected both of these equivalent pairs at the configuration gate:http://LOCALHOST:19082versushttp://localhost:19082http://localhostversushttp://localhost:80After the fix:
[]./v2/org/test-org/nico/site?pageNumber=1andBearer release-case-sentinel.Supporting checks passed:
The
gofmt -lcommand produced no output.How to reproduce the verification
Prerequisites: Go 1.26.4 or newer, Python 3, and
curl.Expected result: the MCP response contains
"text":"[]", and terminal A prints:go test ./mcp/internal/server -run TestFromCallConfig_PrecedenceChain -count=1Expected result: the test passes.