[pull] main from getsentry:main - #424
Merged
Merged
Conversation
* docs(agents): Forbid introducing new catch Throwable Add an "Exception Handling" section to AGENTS.md telling agents to catch the narrowest exception type the guarded code can throw, and to never add a new catch (Throwable). The repo already has ~355 such catches in main sources; they are legacy and should not be read as a precedent. A broad catch swallows OutOfMemoryError, StackOverflowError, ThreadDeath and LinkageError, and hides bugs in our own code behind a log line. The "never crash the host app" requirement is what usually motivates these catches, so the section points at ExceptionUtils.rethrowIfFatal as the way to satisfy it, and calls out the two cases that need care: probing an optional compileOnly dependency via a LinkageError subclass, and not swallowing InterruptedException. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> * docs(agents): Drop the two related cases from Exception Handling The LinkageError and InterruptedException notes were detail the core rule does not need. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )