[pull] main from getsentry:main - #407
Merged
Merged
Conversation
…5837) * fix(replay): Post checkCanRecord to main thread to prevent deadlock onScreenshotRecorded can run on the replay executor thread (PixelCopy masked-capture and emit paths). checkCanRecord -> pauseInternal acquires lifecycleLock — if another thread holds that lock and submits to the same single-threaded executor, we deadlock. When not already on the main thread, post checkCanRecord to the main looper so it never runs on the executor. On main thread, call directly to preserve existing synchronous behavior. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * fix test * fix(replay): Move executor shutdown outside lifecycleLock in close() Holding lifecycleLock while calling awaitTermination() deadlocks if any executor task tries to acquire the same lock. Move shutdown after the lock is released to cut this edge. Ref: #5847 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: Drop ponytail prefix from comment Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * test(replay): Add deadlock test for close() with blocked executor task Verifies close() completes when an executor task is waiting on lifecycleLock, ensuring shutdown happens outside the lock. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )