Skip to content

Add Apple Silicon support & major revamp (3.0.0)#520

Merged
JoniVR merged 183 commits intomasterfrom
experimental/apple-silicon
Aug 21, 2021
Merged

Add Apple Silicon support & major revamp (3.0.0)#520
JoniVR merged 183 commits intomasterfrom
experimental/apple-silicon

Conversation

@waydabber
Copy link
Copy Markdown
Member

This request is about moving 3.0.0 changes to master as discussed.

waydabber and others added 30 commits July 25, 2021 23:59
…nces. Shows current CPU architecture after build number.
…ch are destination screens of a mirrored screen) are now detected and can be controlled. Not tested on Intel but should work.
…y is shadowed in a mirror).

- Display naming now should match System Report.
- Some cleanup (removed unneccesary OSD.framework folder, stuff moved to Bridging-Header.h, removed search location in Build settings, framework proper linked instead).
…ially if not welcome by others. The goal was to somehow have some continuity with the old design, depict an "Apple-ish" display with a brightness OSD but avoid using copyrighted product replicas as requested by the Human Interface Guidelines).
Both can use the same APIs, which seems cleaner for the codebase
@github-pages github-pages bot temporarily deployed to github-pages August 20, 2021 19:01 Inactive
@github-pages github-pages bot temporarily deployed to github-pages August 20, 2021 19:14 Inactive
@waydabber
Copy link
Copy Markdown
Member Author

Hi @JoniVR

I removed the unused images and resolved the issues you mentioned. If you are good to go you can do the merge. I think it's simpler to proceed to an RC1 with the optimization hack and have the issue fixed without hurry for RC2 or the final release. But it's up to you!

Thank you!

Currently, until we fix DDC.swift, we need to set the optimization `-O` flag to `Onone`
@github-pages github-pages bot temporarily deployed to github-pages August 21, 2021 09:21 Inactive
@JoniVR
Copy link
Copy Markdown
Member

JoniVR commented Aug 21, 2021

image
2 Last things:

  • Should we add a link to all collaborators on Github on the about tab? (perhaps below our names?), seems like a minor things but outside collaborators do help out quite a lot.
  • The Contribute button, should we let it go to the actual Github, the one we have now or the one we have on the repo (just the base OpenCollective url)

@the0neyouseek @waydabber thoughts?

I'll try to get this squash merged and get release candidate 1 out later today.

@waydabber
Copy link
Copy Markdown
Member Author

waydabber commented Aug 21, 2021

Yes, adding a link to contributors is a great idea. You mean this one? https://github.com/MonitorControl/MonitorControl/graphs/contributors

I am not entierly sure about the destination of the Contribute button. To be honest, I feel that the donate page is more straightforward than the general landing page where a less determined user might get lost in an instant, which is not exactly what we want. :) But it's up to you guys!

@JoniVR
Copy link
Copy Markdown
Member

JoniVR commented Aug 21, 2021

Yes, adding a link to contributors is a great idea. You mean this one? MonitorControl/MonitorControl/graphs/contributors

Yes, or we could search for a tool that provides a nice overview, but I think that one for now will do.

I am not entierly sure about the destination of the Contribute button. To be honest, I feel that the donate page is more straightforward than the general landing page where a less determined user might get lost in an instant, which is not exactly what we want. :) But it's up to you guys!

This is a bit of a special one imo, because to me, contributors can also be people who contribute code, so we could also rename it to "Donate" or something if we want it to refer to OpenCollective, or replace it with a link to the Repo, where donate buttons are visible and we kinda get both, but less directly.

@waydabber
Copy link
Copy Markdown
Member Author

Ok, I'll add a link to the Contributors page and rename the button to Donate! I'll push it in an instant!

@waydabber
Copy link
Copy Markdown
Member Author

waydabber commented Aug 21, 2021

It would look like this. But I need a bit more time sorry as I cannot solve the problem of the mouse not changing into a hand style over the link lol. :)

Screen Shot 2021-08-21 at 12 33 02

@waydabber
Copy link
Copy Markdown
Member Author

Ok, whatever... It will not have a hand cursor. Tried like 4 techniques and I simply cannot change the cursor to look like a hand over that piece of text amazingly lol.

@github-pages github-pages bot temporarily deployed to github-pages August 21, 2021 11:13 Inactive
@waydabber
Copy link
Copy Markdown
Member Author

@JoniVR - i committed the changes. You can go on! :)

Copy link
Copy Markdown
Member

@JoniVR JoniVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All Good, fantastic work @waydabber! Will work on getting it released in the next 2 hours, have some other stuff going on.

I'll also create a v3.1.0 branch once it's merged in, and then perhaps we should setup Github Projects with milestones so we can track and plan for v3.1.0?

@JoniVR JoniVR merged commit d46c429 into master Aug 21, 2021
@JoniVR JoniVR deleted the experimental/apple-silicon branch August 21, 2021 11:18
@waydabber
Copy link
Copy Markdown
Member Author

Great, thank you! :)

@waydabber
Copy link
Copy Markdown
Member Author

Btw, I agree with the milestone approach, It would be great to track which issue is fixed in which release and also have some kind of general idea where the development is heading.

Whenever I have the time I am trying to go through the issues backlog, reply and close those that we can't do much about so we only have relevant issues and feature requests. Its such a heavy work though since we had so many issues open. Still, there is some progress, the number of open issues is now below 100 finally! :)

I think it would be great to somehow recruit some expert community members who try to help out others as a first line of defense so only those issues are escalated to devs which are really issues or valid requests.

@JoniVR
Copy link
Copy Markdown
Member

JoniVR commented Aug 21, 2021

Btw, I agree with the milestone approach, It would be great to track which issue is fixed in which release and also have some kind of general idea where the development is heading.

Great, I'll get it set up!

Whenever I have the time I am trying to go through the issues backlog, reply and close those that we can't do much about so we only have relevant issues and feature requests. Its such a heavy work though since we had so many issues open. Still, there is some progress, the number of open issues is now below 100 finally! :)

I think it would be great to somehow recruit some expert community members who try to help out others as a first line of defense so only those issues are escalated to devs which are really issues or valid requests.

Yeah, I tried for a long time to keep the number of issues in check, but at one point we were getting insane amounts of new users and issues and I just couldn't keep up anymore. I feel like we didn't grow contributors in correlation to users, which is why we got overwhelmed, I'm very glad to have you with us now and I agree we should probably soon look for some extra people to help.

@JoniVR
Copy link
Copy Markdown
Member

JoniVR commented Aug 21, 2021

As a side note, I think the amount of new issues got decreased quite a bit by the new issue templates, since they are much clearer to users and force them to actually read and fill out the templates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants