Fix DDC reliability on latest Xcode versions, migrate to SPM, more fixes#453
Merged
Fix DDC reliability on latest Xcode versions, migrate to SPM, more fixes#453
Conversation
…ncies Switching to SPM also fixed #238
Member
|
As always, thanks for the awesome work @JoniVR |
the0neyouseek
approved these changes
Jun 15, 2021
Member
the0neyouseek
left a comment
There was a problem hiding this comment.
Everything looks good to me ! Great job as always 👌
| // MonitorControl | ||
| // | ||
| // Created by Joni Van Roost on 22/11/2020. | ||
| // Copyright © 2020 Guillaume Broder. All rights reserved. |
Member
There was a problem hiding this comment.
We should remove my name from the "Organization" field in the xcodeproj to remove copyright mentions when generating new files. (And also remove them from current files in the future)
Member
Author
There was a problem hiding this comment.
Done 🙂 The only place I haven't updated is the bundle identifier since I thought that'd probably have an impact on other things.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the following changes:
NSGridViewfor preferences layout.This PR is mostly needed so we can actually have a working build again (and hopefully merge some of the open PRs that have been blocked by this). It will probably introduce some conflicts in other PRs (storyboard hell) but still seems necessary in order to test them reliably.
Fixes #238
Closes #448