Add GitHub Actions Build#295
Add GitHub Actions Build#295JoniVR merged 23 commits intoMonitorControl:masterfrom stephengroat:github-actions
Conversation
| push: | ||
| branches: [ master ] | ||
| pull_request: | ||
| branches: [ master ] |
There was a problem hiding this comment.
I think this only runs when the pull request head branch is master, which is why it isn't working for this pull request.
There was a problem hiding this comment.
works on my fork pr https://github.com/stephengroat/MonitorControl/pull/1, maybe it has to be merged in?
There was a problem hiding this comment.
Yes I think that this should work, CI should run when changes are merged into master and for each PR. It's probably indeed due to needing to be merged in first.
There was a problem hiding this comment.
I opened up a test PR on your branch (https://github.com/stephengroat/MonitorControl/pull/2), seems like it fails the build now throwing a linking error for Swiftlint.
My best guess is it's probably the brew link step that can go since SwiftLint seems to be included by default on macOS for Github Actions? Not sure.
|
@JoniVR unfortunately, I've asked for access to the private preview, I'll have to see what happens |
|
Hi, thanks for your effort, it's much appreciated. I did some reading and found the following: They state it might take 2-3 days to propagate so that would hopefully solve it then. |
|
Hi @JoniVR, |
|
Hi, thanks for pinging me here. So our best bet seems to be just creating a workflow (any workflow) that triggers Github Actions, after that it should work if I read everything correctly? |
|
Correct, you can try it with |
|
I ran a CI action from a separate branch, is that sufficient? The actions tab seems to indicate that it ran. |
|
Yes, confirming that I can find the required key now, will provide access today. Thanks! |
|
Thanks for the help, much appreciated! |
|
macOS 11 should be accessible for you now, please check, and let me know if it doesn't work 🙂 |
|
Thanks for the PR @stephengroat! |
Note: This does change the
Debugscheme to use locally signed certs instead of the team cert. This shouldn't affect release builds