Fix typo in create_datagram_endpoint#46
Conversation
|
Hi! Thank you for this PR! Would you be able to write a regression test? |
|
I'll see what I can do with different loopback address. |
|
Okay, I've modified the UDP test case to set a fixed local_addr of If you rather a separate test case, I can do that too, but mind giving me some pointers how I should organise things? |
|
@vodik With this PR Would it work if we bind |
|
Yeah, that works. Actually, there's no reason to use a second address so long as we bind to port 0. Still fails on master/passed with fix. |
|
Alright, could you please remove the unittest part from your PR and I'll merge it then. I'll try to figure out a way to test this properly later. |
Typo causes create_datagram_endpoint to send traffic to the local_addr instead of the remote_addr. Closes MagicStack#45.
|
No problem. I don't have a mac so I can't lend a hand. Figuring out something more proper might benefit the TCP tests too. Maybe its as simple as putting them as a different test and documenting that 127.0.0.2 needs to be added to loopback. My understanding, after googling around, is that it works on mac. Just the networking stack defaults to 127.0.0.1/32 instead of 127.0.0.1/8. |
|
Merged, thanks a lot! |
|
Releasing 0.5.3 right now. |
Typo causes
create_datagram_endpointto send traffic to thelocal_addrinstead of theremote_addr.Closes #45.