Snippets: env moved to be out-of-string, new variants, future import snips - #68
Closed
ambv wants to merge 1 commit into
Closed
Snippets: env moved to be out-of-string, new variants, future import snips#68ambv wants to merge 1 commit into
ambv wants to merge 1 commit into
Conversation
…snips Title says all. Test plan: `make test`, passed. Installed locally, new snips work, env only works outside of strings.
Author
|
Didn't bother to update the Sublime snippets as I saw they are already out-of-sync. |
Author
|
With this you can release :-) |
Member
So this PR syncs snippets with the official atom/language-python snippets? |
Author
|
No, I added a few that I was using in Vim. I see atom/language-python is what you had before. Would you like me to also submit those changes to atom/language-python? |
Member
Yes, I think the right way is to have them accepted there first. We try not to add features (besides better syntax highlighting) that aren't implemented in atom/sublime default packages. |
Author
|
I see, alright, might be sensible to add this info somewhere :-) |
This was referenced Jul 19, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title says all.
Test plan:
make test, passed. Installed locally, new snips work, env onlyworks outside of strings.