Shikimori - GraphQL #2829
Open
Shikimori - GraphQL #2829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I think it's safe to review now |
5f7528a to
170ce9f
Compare
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
lolamtisch
requested changes
Jul 17, 2025
src/_provider/Shikimori/queries.ts
Outdated
| }, | ||
| }).then((res: Types.CurrentUser) => { | ||
| // TODO - Waiting for GRAPHQL update | ||
| // if (res.locale) { |
Member
There was a problem hiding this comment.
This is unfortunate. As this will result in mixed languages in the popup. RU title with English descriptions and headers. I am fine with it tho, as I imagine most people have Shiki set to RU either way
Contributor
Author
There was a problem hiding this comment.
I added old request back, can you try this one again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially moved Shikimori to GRAPHQL API
Problem: While Shikimori uses old REST API, there's no way to user to search for LNs/WNs in correction search or normal search using Shiki as primary provider. That is due to manga and novels being separate API endpoints while other providers (MAL, AL etc.) merged them together under name "Manga".
Updating to GQL allow to search for both manga types and novel types at the same time since their API merged novels with manga.
Implementation modifies almost all Shikimori files, so there's a need for writing a tests (I think).
Some notable changes:
Also some spelling fixes.