perf: sort window rows in place#376
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #376 +/- ##
=======================================
Coverage 92.84% 92.85%
=======================================
Files 249 249
Lines 41790 41844 +54
=======================================
+ Hits 38802 38856 +54
Misses 2988 2988
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Window execution currently depends on a separate Sort executor. Sort materializes the input before Window buffers it again, creating an unnecessary second materialization for window queries.
Issue link: N/A
What is changed and how it works?
Code changes
Check List
Tests
The coverage verifies in-place tuple ordering, Window executor partition and peer evaluation, ranking and aggregate window results, multiple window specifications, and Explain plans without standalone Sort nodes.
Side effects
Note for reviewer
Window remains a blocking operator because it must order its input, but it now performs that ordering in its own row buffer instead of materializing rows in both Sort and Window.