fix(vscode): declare Pierre worker dependency for builds#10753
Open
lambertjosh wants to merge 1 commit into
Open
fix(vscode): declare Pierre worker dependency for builds#10753lambertjosh wants to merge 1 commit into
lambertjosh wants to merge 1 commit into
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (2 files)
Reviewed by claude-sonnet-4.6 · 409,798 tokens Review guidance: REVIEW.md from base branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Declare
@pierre/diffsdirectly inpackages/kilo-vscodeand update its Bun lockfile importer entry.Why
PR #10730 added extension-owned direct consumers of Pierre's worker APIs:
packages/kilo-vscode/esbuild.jsnow resolves@pierre/diffs/worker/worker.jsfor the bundled Shiki worker asset, andpackages/kilo-vscode/webview-ui/pierre-worker.tsimports@pierre/diffs/worker. It did not add@pierre/diffsto the extension package dependencies.Under Bun's isolated workspace installs, the extension cannot depend on
@pierre/diffsbeing present only through sibling UI packages. A clean extension build therefore fails in the production esbuild path with:Declaring the dependency at the package that directly consumes it preserves the worker implementation and avoids relying on accidental hoisting or cross-workspace dependency visibility.
Release and CI context
The
v7.3.18pre-release workflow began before #10730 merged: itsbuild-vscodejob checked out7bbac24c696403e658c78e7dfb494b0a5c9c5944, and the published VSIX artifacts do not contain thedist/shiki-worker.jsasset introduced by that PR. This is therefore a correction for currentmainbefore an affected VSIX ships, rather than a shipped behavior change requiring release notes.The regression passed PR checks because the VS Code checks exercise unit tests, linting, filtered typechecking, Knip, and Storybook visual builds, but do not execute the production extension
node esbuild.js --productionbundle path that creates the synthetic worker entry. This PR applies the minimal dependency ownership fix; adding production bundle coverage to PR CI should be handled as follow-up prevention work.