refactor(cli): remove Session promise facade#10725
Draft
marius-kilocode wants to merge 1 commit into
Draft
Conversation
Collaborator
Author
|
This is just for reference, don't merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sessionwas one of the final services still exposing a Kilo-added runtime-backed Promise facade. That compatibility layer kept Kilo callers and behavior setup coupled to a service-local runtime, and prevented the strict facade ratchet from removing its Session exception.This removes the Session Promise adapter block while preserving the durable
Session.forkrecursive child-remap extension. Message and part validation now lives at the service mutation boundary, so direct service consumers retain the validation behavior that previously sat in the deleted wrappers. Effect-native Kilo workflows consumeSession.Servicedirectly, while Promise-shaped integration boundaries use the shared application runtime instead of rebuilding a Session-local runtime. Related behavior setup now reaches Session through scoped layers rather than the deleted helpers.This overlaps with the parallel Question and SessionPrompt facade work in plan-followup, remote-sender, and prompt-queue surfaces. The later-integrated branch must preserve each already-landed service migration. If the open session-export work lands first, its additions in
session.tsmust be reconciled without restoring the removed facade.Closes #10722
Part of #10655