Skip to content

refactor(code-review): remove code-review logic from cloud-agent#3528

Draft
alex-alecu wants to merge 4 commits into
mainfrom
docs/code-review-do-boundary
Draft

refactor(code-review): remove code-review logic from cloud-agent#3528
alex-alecu wants to merge 4 commits into
mainfrom
docs/code-review-do-boundary

Conversation

@alex-alecu
Copy link
Copy Markdown
Contributor

Summary

This change makes it clear which part of the system decides how a code review runs and which part only runs shared agent sessions. It helps keep future review rules out of shared session handling. Old notes that pointed to a removed local code location now describe the current ownership split.

Verification

  1. Read the code-review service guidance and confirm it keeps review decisions in the review runner while leaving shared session work to the cloud-agent service.
  2. Read the cloud-agent guidance and confirm it does not take ownership of review attempts or retry choices.
  3. Check the command-policy comments and confirm they describe the active permission owner without changing command lists.

Visual Changes

N/A

Reviewer Notes

Documentation and comments only; no command rules, APIs, service routing, or runtime behavior changed. A leftover ignored local directory was removed locally and is intentionally absent from the tracked diff.

@kilo-code-bot
Copy link
Copy Markdown
Contributor

kilo-code-bot Bot commented May 27, 2026

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Executive Summary

Incremental commit (5c9415d7) correctly addresses two follow-on concerns: (1) managed continuation calls no longer re-send mode/model/variant overrides (relying on session-stored agent selection instead), and (2) lastAssistantMessageText is stripped from completionData at the outbox boundary via withoutDuplicatedAssistantText to eliminate the field duplication introduced in the previous commit — both fixes are fully backed by new tests.

Files Reviewed (incremental — 11 files in new commit)
  • packages/worker-utils/src/cloud-agent-next-client.tsCloudAgentSendMessageInternalInput now makes mode/model/variant optional; correct
  • services/cloud-agent-next/src/callbacks/types.tslastAssistantMessageText removed from completionData shape; correct
  • services/cloud-agent-next/src/persistence/CloudAgentSession.ts — corresponding removal in DO completionData assembly; correct
  • services/cloud-agent-next/src/router/schemas.tsTrustedSendMessageV2FlatInput / TrustedPromptSendPayload make mode/model optional; correct
  • services/cloud-agent-next/src/router/schemas.test.ts — new test covers trusted continuation without overrides; correct
  • services/cloud-agent-next/src/session/message-settlement-outbox.tswithoutDuplicatedAssistantText helper strips field at both outbox paths; correct
  • services/cloud-agent-next/src/session/session-message-queue.test.ts — new test verifies stored agent selection used when no overrides present; correct
  • services/cloud-agent-next/test/integration/session/callback-notification.test.ts — asserts completionData does not contain lastAssistantMessageText; correct
  • services/cloud-agent-next/test/integration/session/message-terminalization.test.ts — same assertion; correct
  • services/code-review-infra/src/code-review-orchestrator.ts — removes mode/model/variant from sendMessageV2Internal call; correct
  • services/code-review-infra/test/integration/code-review-orchestrator.test.ts — assertions updated for new API shape; correct

Fix these issues in Kilo Cloud


Reviewed by claude-sonnet-4.6 · 822,625 tokens

Review guidance: REVIEW.md from base branch main

@alex-alecu alex-alecu changed the title docs(code-review): clarify do boundary docs(code-review): remove code-review logic from cloud-agent May 27, 2026
@alex-alecu alex-alecu changed the title docs(code-review): remove code-review logic from cloud-agent refactor(code-review): remove code-review logic from cloud-agent May 27, 2026
Reuse persisted agent defaults for follow-ups and avoid duplicating assistant response text in completion metadata.
@alex-alecu alex-alecu marked this pull request as draft May 28, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant