Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugs fixed:
Login from profile page (CodeYourFuture#6): views/profile.mjs and views/hashtag.mjs were binding the login handler to a nonexistent click target instead of the form's submit event — so the login form silently fell back to a native HTML form submission (POST to the page itself), which a static file server can't handle, hence the 501. Now wired correctly.
Extra-long blooms (CodeYourFuture#4): backend had no length check on posted content. Added a 280-char server-side validation in send_bloom, and trimmed the one seed bloom that exceeded it.
Hashtag link bug (CodeYourFuture#5): the hashtag-linking regex (\B#[^#]+) greedily consumed everything to the end of the bloom instead of stopping at the word boundary. Fixed to \B#\w+.
Hashtag page flashing (CodeYourFuture#3): hashtagView fetched data unconditionally on every render, and since fetches trigger a state change that re-runs the view, it looped infinitely. Added a guard so it only re-fetches when the hashtag actually changes.
Features added:
Unfollow (CodeYourFuture#8): new /unfollow/ backend endpoint + unfollow() in data/follows.py; profile's Follow button now toggles to "Unfollow" when already following.
Rebloom (CodeYourFuture#9): new reblooms table, backend endpoint (/rebloom), and feed logic that merges original posts with reblooms (sorted by whichever happened more recently), tagging each with rebloom count and "Rebloomed by X". Frontend has a Rebloom button + count on every bloom.