Skip to content

Properly override versionSuffix for release builds and add build number in CI #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Inumedia merged 1 commit into from
Nov 7, 2018
Merged

Properly override versionSuffix for release builds and add build number in CI #149

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions build.cake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ Task("Configure")
// following SevVer 2.0.0 rules. MyGet supports SemVer 2.0.0
if (isReleaseBuild)
{
versionSuffix = string.Empty;
versionSuffix = "\"\"";
}
else
{
Expand Down Expand Up @@ -76,8 +76,7 @@ Task("Configure")
}

var versionPrefix = XmlPeek("./Directory.Build.props", "/Project/PropertyGroup/VersionPrefix");
var version = string.Join("-", versionPrefix, versionSuffix);

var version = isReleaseBuild ? $"{versionPrefix}-release.{buildNumber}" : string.Join("-", versionPrefix, versionSuffix);
if (AppVeyor.IsRunningOnAppVeyor)
{
// Update AppVeyor build version so it will match the build version in assemblies and package
Expand Down Expand Up @@ -210,7 +209,7 @@ Task("Publish")
var apiToken = EnvironmentVariable(config.token);
if (string.IsNullOrEmpty(apiToken))
{
Error("{0} environment variable not found. Unable to push package on {1}", config.token, config.provider);
Warning("{0} environment variable not found. Unable to push package on {1}", config.token, config.provider);
}
else
{
Expand Down