Simplify asserts in dlpack tests#1310
Merged
antonwolfy merged 4 commits intoIntelPython:masterfrom Feb 27, 2023
Merged
Conversation
oleksandr-pavlyk
approved these changes
Feb 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #1016 dpctl will use a dedicated queue cache with (context, device) pair.
The cache will be available in
dpctl.tensor.from_dlpack, so it will return the same queue for a given device.Thus the PR is to update corresponding tests in dpnp and simplify the verifications asserts by a common function.