Fixed gh-998: exception raised while forming an expected TypeError exception message #999
Conversation
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/999/index.html |
invalid/unsupported data types.
7d010b1 to
05cb7fc
Compare
|
Array API standard conformance tests for dpctl=0.14.0=py310h8c27c75_13 ran successfully. |
| return descr_to_typenum(dt) | ||
| else: | ||
| return -1 | ||
| except TypeError: |
There was a problem hiding this comment.
I believe except * in the definition of dtype_to_typenum isn't needed anymore also, since no exception is raised by the function.
There was a problem hiding this comment.
Correct. This is an optimization change though. It does not hurt to keep it.
I will push the suggested change and merge.
|
Array API standard conformance tests for dpctl=0.14.0=py310h8c27c75_14 ran successfully. |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.0=py310h8c27c75_14 ran successfully. |
This change fixes formation of
TypeErrormessage string.Closes #998.
It also reworks
dtypeargument validation, fixing unreferenced issue withdpt.usm_ndarray(1, dtype=np.dtype(">f4")).