Sycl kernel api by oleksandr-pavlyk · Pull Request #970 · IntelPython/dpctl

oleksandr-pavlyk · 2022-11-05T23:36:37Z

This PR add Cython generated c-api for dpctl.program.SyclKernel and dpctl.program.SyclProgram classes.

dpctl4pybind11 adds type casters to map dpctl.program.SyclKernel to sycl::kernel and
dpctl.program.SyclProgram to sycl::kernel_bundle<sycl::bundle_state::executable>.

This PR closes #943.

Have you provided a meaningful PR description?
Have you added a test, reproducer or referred to an issue with a reproducer?
Have you tested your changes locally for CPU and GPU devices?
Have you made sure that new changes do not introduce compiler warnings?
If this PR is a work in progress, are you filing the PR as a draft?

Nullptr is also handled, interpreting it as "default_name". Pybind11 caster provides a fixed name 'dpctl4pybind11_kernel'

New checks are complete with docstrings, check for SyclKernel_Make also checks the nullptr for name usage.

github-actions · 2022-11-05T23:50:50Z

View rendered docs @ https://intelpython.github.io/dpctl/pulls/970/index.html

coveralls · 2022-11-05T23:54:31Z

Coverage increased (+0.04%) to 82.032% when pulling c873896 on sycl-kernel-api into 2c86ef6 on master.

github-actions · 2022-11-06T00:00:29Z

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_27 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

github-actions · 2022-11-06T04:38:56Z

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_28 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

github-actions · 2022-11-06T14:08:01Z

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_29 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

github-actions · 2022-11-06T14:46:24Z

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_30 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

…le_Copy Also change commented out, or preprocessor disabled code for testing, implementing, or declaring DCPTLKernel_GetMaxSubGroupsSize since it is now supported in 2023 compiler.

github-actions · 2022-11-06T15:58:44Z

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_30 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

github-actions · 2022-11-06T16:17:14Z

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_31 ran successfully.
Passed: 32
Failed: 802
Skipped: 3138

oleksandr-pavlyk · 2022-11-06T17:08:44Z

@ndgrigorian The DPCTLKernel_GetName used to exist before, see https://github.com/IntelPython/dpctl/blob/0.12.0/libsyclinterface/include/dpctl_sycl_kernel_interface.h#L41-L52

I removed while refactoring from use of deprecated sycl::program to SYCL-2020 compliant sycl::kernel_bundle in #845 which made it into 0.13.0

github-actions · 2022-11-06T22:00:12Z

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_32 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

…API functions dpctl_capi constructor must initialize DPCTLKernel_GetKernelRef_ and DPCTLKernelBundle_GetKernelBundleRef_ for casters to work correctly.

github-actions · 2022-11-07T15:25:51Z

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_35 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

…Kernel

github-actions · 2022-11-07T19:51:59Z

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_43 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

ndgrigorian

LGTM, thanks for writing the tests

diptorupd · 2022-11-07T22:03:27Z

+import dpctl.tensor as dpt
+
+q = dpctl.SyclQueue()
+


Some documentation is warranted. I know what the example is doing, but not every user will know or should be expected to know just by reading the code.

diptorupd

LGTM.

I have a general comment about the state of dpctl4pybind11.hpp. The file needs API docs and we should generate the API doc and add it to our documentation page.

oleksandr-pavlyk · 2022-11-07T22:48:23Z

I am going to push suggested changes, which will dismiss approvals. I am going to wait for @chengjunlu's feedback and merge this tomorrow.

github-actions · 2022-11-08T00:25:55Z

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_44 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

github-actions · 2022-11-08T02:34:17Z

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_45 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

github-actions · 2022-11-08T02:59:47Z

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

github-actions · 2022-11-08T03:20:38Z

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_45 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

ndgrigorian and others added 7 commits November 4, 2022 11:23

C API for SyclProgram and SyclKernel classes

35df171

Applied pre-commit linter

be9ea33

Implemented DPCTLKernel_GetName

0da4e4c

SyclKernel_Make now takes KernelRef and const char * for the name.

a3ce695

Nullptr is also handled, interpreting it as "default_name". Pybind11 caster provides a fixed name 'dpctl4pybind11_kernel'

Added tests for cpython_api for SyclProgram and SyclKernel

8c20dc4

New checks are complete with docstrings, check for SyclKernel_Make also checks the nullptr for name usage.

Merge remote-tracking branch 'origin/master' into sycl-kernel-api

fe4294b

Adjusted use of wrap/unwrap to templated as per changes in master

90a453a

Removed DPCTLKernel_GetName as unused

69d3c7e

Make sure _program.h and _program_api.h are copied to the layout

35f93a3

Added libsyclinterface/tests for DCPTLKernel_Copy and DPCTLKernelBund…

ea19360

…le_Copy Also change commented out, or preprocessor disabled code for testing, implementing, or declaring DCPTLKernel_GetMaxSubGroupsSize since it is now supported in 2023 compiler.

oleksandr-pavlyk force-pushed the sycl-kernel-api branch from 63e4e98 to ea19360 Compare November 6, 2022 15:36

Condition test exercising fp16 support on availability of HW support

50268dd

oleksandr-pavlyk marked this pull request as ready for review November 6, 2022 17:04

oleksandr-pavlyk requested review from diptorupd and ndgrigorian November 6, 2022 17:04

ndgrigorian reviewed Nov 6, 2022

View reviewed changes

Comment thread dpctl/apis/include/dpctl4pybind11.hpp Outdated

Fixed text of py::type_error per PR review

753548b

Added missing initialization of function pointers for dpctl.program C…

375fa77

…API functions dpctl_capi constructor must initialize DPCTLKernel_GetKernelRef_ and DPCTLKernelBundle_GetKernelBundleRef_ for casters to work correctly.

Added an example to exercise pybind11 bindings for dpctl.program.Sycl…

a309aa2

…Kernel

ndgrigorian previously approved these changes Nov 7, 2022

View reviewed changes

oleksandr-pavlyk mentioned this pull request Nov 7, 2022

dpctl doesn't support the cl::sycl::kernel in pybind11 #943

Closed

diptorupd reviewed Nov 7, 2022

View reviewed changes

Comment thread dpctl/apis/include/dpctl4pybind11.hpp Outdated

diptorupd reviewed Nov 7, 2022

View reviewed changes

Comment thread dpctl/apis/include/dpctl4pybind11.hpp

diptorupd reviewed Nov 7, 2022

View reviewed changes

Comment thread examples/pybind11/use_dpctl_sycl_kernel/README.md Outdated

diptorupd reviewed Nov 7, 2022

View reviewed changes

diptorupd previously approved these changes Nov 7, 2022

View reviewed changes

Addressed PR feedback, remove unused struct member fields

49efb61

oleksandr-pavlyk dismissed stale reviews from diptorupd and ndgrigorian via 49efb61 November 8, 2022 00:00

Added comments, and updated README.md

c873896

oleksandr-pavlyk merged commit f6b0c36 into master Nov 8, 2022

oleksandr-pavlyk deleted the sycl-kernel-api branch November 8, 2022 02:59

Conversation

oleksandr-pavlyk commented Nov 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 5, 2022

Uh oh!

coveralls commented Nov 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Nov 6, 2022

Uh oh!

github-actions Bot commented Nov 6, 2022

Uh oh!

github-actions Bot commented Nov 6, 2022

Uh oh!

github-actions Bot commented Nov 6, 2022

Uh oh!

github-actions Bot commented Nov 6, 2022

Uh oh!

github-actions Bot commented Nov 6, 2022

Uh oh!

oleksandr-pavlyk commented Nov 6, 2022

Uh oh!

Uh oh!

github-actions Bot commented Nov 6, 2022

Uh oh!

github-actions Bot commented Nov 7, 2022

Uh oh!

github-actions Bot commented Nov 7, 2022

Uh oh!

ndgrigorian left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

diptorupd Nov 7, 2022

Choose a reason for hiding this comment

Uh oh!

diptorupd left a comment

Choose a reason for hiding this comment

Uh oh!

oleksandr-pavlyk commented Nov 7, 2022

Uh oh!

github-actions Bot commented Nov 8, 2022

Uh oh!

github-actions Bot commented Nov 8, 2022

Uh oh!

github-actions Bot commented Nov 8, 2022

Uh oh!

github-actions Bot commented Nov 8, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

oleksandr-pavlyk commented Nov 5, 2022 •

edited

Loading

coveralls commented Nov 5, 2022 •

edited

Loading