Skip to content

Fixed issue in asarray_from_numpy for uint64 dtype. #949

Merged
oleksandr-pavlyk merged 5 commits intomasterfrom
fix-issue-948
Oct 21, 2022
Merged

Fixed issue in asarray_from_numpy for uint64 dtype. #949
oleksandr-pavlyk merged 5 commits intomasterfrom
fix-issue-948

Conversation

@npolina4
Copy link
Copy Markdown
Contributor

@npolina4 npolina4 commented Oct 21, 2022

Fixed issue #948 in asarray_from_numpy for uint64 dtype. And changed call copy_to function

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?

@npolina4 npolina4 marked this pull request as ready for review October 21, 2022 01:45
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 21, 2022

View rendered docs @ https://intelpython.github.io/dpctl/pulls/949/index.html

@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented Oct 21, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.06%) to 82.047% when pulling eb9b652 on fix-issue-948 into 2723947 on master.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 21, 2022

Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_199 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 21, 2022

Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_200 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor

oleksandr-pavlyk commented Oct 21, 2022

FYI, change from res[...] = ary to call to ti._copy_numpy_ndarray_into_usm_ndarray(src=ary, dst=res, sycl_queue=copy_q) break test runs on Iris Xe, because logic in __setitem__ adapts to this scenario by downcasting on the host.

@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor

oleksandr-pavlyk commented Oct 21, 2022

Please run pre-commit install in your environment.

@oleksandr-pavlyk
asarray to use mapping from ndarray data type to usm_ndarray type
eb9b652 
This mapping taking into account device aspects.
@oleksandr-pavlyk
Copy link
Copy Markdown
Contributor

oleksandr-pavlyk commented Oct 21, 2022 •
edited
Loading

I pushed a commit to address the weakness in deducing asarray(x) output type from the input type and the device information.

I have also replaced use of res[...] = ary to fix test run on Iris Xe.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 21, 2022

Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_201 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk oleksandr-pavlyk merged commit 52773aa into master Oct 21, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-issue-948 branch October 21, 2022 21:27
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 21, 2022

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 21, 2022

Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_201 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Oct 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@npolina4 @coveralls @oleksandr-pavlyk