[cleanup/tensor, part5] Moved implementation of every Python binding into separate translation unit#934
Merged
oleksandr-pavlyk merged 8 commits intocleanup/tensorfrom Oct 17, 2022
Conversation
…ed file Also moved routine for simplification of iteration space into dedicated file
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/934/index.html |
|
Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_189 ran successfully. |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves each Python function definition and the initialization of function pointer tables/vectors used in
tensor_py.cppinto dedicated.cppfiles. Definitions reside indpctl::tensor::py_internalnamespace.Going forward, adding a new function to
dpctl.tensor._tensor_implwould involve:.cppand.hppfile with implementation and declarations.cppto list of sources in "dpctl/tensor/CMakeLists.txt"