[cleanup/tensor, part 4] Made contract_iter and contract_iter2 functions templated to avoid needing to include pybind11 headers#933
Merged
oleksandr-pavlyk merged 1 commit intocleanup/tensorfrom Oct 16, 2022
Conversation
This is avoid using py::value_error and py::ssize_t and py::type_error in there explicitly. Use in tensor_py.cpp adjusted
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/933/index.html |
|
Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_180 ran successfully. |
Contributor
Author
|
I think this is pretty straightforward commit, so I am going to merge it. |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code for
contract_iterandcontract_iter2functions in "strided_iters.hpp" used identifiers from::pybind11namespace.Made these functions templated passing necessary types via template parameters.
This is avoid using py::value_error and py::ssize_t and py::type_error in there explicitly.
Use in "tensor_py.cpp" has been adjusted.